Support Arithmetic function ROUND #615
Conversation
LeeJejune
requested review from
cj848,
huisam,
pickmoment and
shouwn
as code owners
|
|
render/jpql/src/main/kotlin/com/linecorp/kotlinjdsl/render/jpql/JpqlRenderContext.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * Creates an expression that represents the rounding of the specified property's value to a specified scale. |
There was a problem hiding this comment.
I think it would be great to at least value instead of property's value, since not only the value of the property can be passed as a parameter to round, but also the literal.
| * Creates an expression that represents the rounding of the specified property's value to a specified scale. | ||
| */ | ||
| @SinceJdsl("3.4.0") | ||
| fun <T : Any, V : Number> round(expr: KProperty1<T, @Exact V>, scale: Expression<Int>): Expression<Double> { |
There was a problem hiding this comment.
I don't think the ROUND is a primary function, so I think it would be better to have the function located below the DIV.
| * Creates an expression that represents the rounding of the specified property's value to a specified scale. | ||
| */ | ||
| @SinceJdsl("3.4.0") | ||
| fun <T : Number> round(value: Expressionable<T>, scale: Expressionable<Int>): Expression<Double> { |
There was a problem hiding this comment.
In the jakarta specification, the return type of ROUND is the same type as the first argument: value.
Could you test this to make sure it's really correct? I think it would be okay to test with Int, Double, and BigDecimal only.
|
I would modify a bit from what you wrote, just the method names and such. Thanks for the help! |
|
Oh, and I was expecting you to use the example module to test that Double and Int work with JPA locally. |
4 participants
Motivation
Modifications
Commit Convention Rule
commit typeplease describe it on the Pull RequestResult
roundis created.Closes