Merged
Conversation
Contributor
trustin
reviewed
Apr 23, 2024
trustin
reviewed
Apr 24, 2024
ikhoon
reviewed
Apr 26, 2024
…tion/AnnotatedDocServicePlugin.java Co-authored-by: Ikhun Um <[email protected]>
…tion/DefaultAnnotatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…onfigSetters.java Co-authored-by: Ikhun Um <[email protected]>
…onfigSetters.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tatedService.java Co-authored-by: Ikhun Um <[email protected]>
…tion/AnnotatedDocServicePlugin.java Co-authored-by: Ikhun Um <[email protected]>
…tion/AnnotatedDocServicePlugin.java Co-authored-by: Ikhun Um <[email protected]>
trustin
reviewed
Apr 30, 2024
…onfigSetters.java Co-authored-by: Trustin Lee <[email protected]>
…erviceNamingUtil.java Co-authored-by: Trustin Lee <[email protected]>
ikhoon
approved these changes
May 2, 2024
Contributor
ikhoon
left a comment
There was a problem hiding this comment.
Nice work! Thanks, @chickenchickenlove. 🙇♂️🙇♂️
jrhee17
approved these changes
May 3, 2024
Contributor
jrhee17
left a comment
There was a problem hiding this comment.
Pushed a small commit with minor cleanups. Thanks @chickenchickenlove ! 🙇 👍 🙇
minwoox
approved these changes
May 7, 2024
Contributor
minwoox
left a comment
There was a problem hiding this comment.
Looks really great! Thanks, @chickenchickenlove! 👍 👍 👍
…tion/DefaultAnnotatedService.java
Member
|
Please make sure the PR description is up to date and has no grammar errors or incorrect class names next time. Also, please do not mix up motivation, modification and result. For example, what you initially wrote at the motivation section is the result of your work. |
Contributor
Author
|
Thanks for your comment. |
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this pull request
Jun 8, 2024
Motivation: - Related issue: line#5382 - It'd be nice if a user can access the information provided by `AnnotatredService`, but it is not part of the public API. ### Modifications: - Split `AnnotatedService` into `AnnotatedService` (interface) and `DefaultAnnotatedService` (implementation). ### Result: - Closes line#5382 Before: ```java ServiceRequestContext serviceRequestContext = ServiceRequestContext.current(); AnnotatedService service = serviceRequestContext.config().service().as(AnnotatedService.class); // This doesn't compile. // service.method(); // service.defaultStatus(); ``` After: ```java ServiceRequestContext serviceRequestContext = ServiceRequestContext.current(); AnnotatedService service = serviceRequestContext.config().service().as(AnnotatedService.class); // This compiles and provides useful properties. service.method(); service.defaultStatus(); ``` --------- Co-authored-by: Ikhun Um <[email protected]> Co-authored-by: Trustin Lee <[email protected]> Co-authored-by: jrhee17 <[email protected]> Co-authored-by: minux <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation:
AnnotatedServiceprovided specialized information for annotated services such asMethod,service instance, and thedefault status, and so on. however, users could not access this information because it was declared with apackage-privateaccess modifier, so it was not part of the public API.Modifications:
AnnotatedServiceinto two parts:AnnotatedService(interface) andDefaultAnnotatedService(implementation).AnnotatedService: The methods that can be used by users through the Public API are declared in theAnnotatedServiceinterface.DefaultAnnotatedService: Methods intended for internal use are declared inDefaultAnnotatedService.Result:
AnnotatedServicepublic #5382AnnotatedServiceavailable through a public API.