packages/language-server/CHANGELOG.md-19-19 (1)

19-19: ⚠️ Potential issue | 🟡 Minor

Add a language tag to the fenced code block.

MD040 is triggered because the opening fence lacks a language. Consider restoring likec4 (or text) for proper rendering.

💡 Suggested fix

-  ```
+  ```likec4

packages/log/src/formatters.ts-49-58 (1)

49-58: ⚠️ Potential issue | 🟡 Minor

Typo in variable name: errorMessge → errorMessage.

Used consistently across lines 49–58 so there's no runtime breakage, but it's clearly a misspelling.

Proposed fix

-    let errorMessge = error.message
+    let errorMessage = error.message
     if (error.stack) {
-      errorMessge = errorMessge + '\n' + indent(error.stack.split('\n').slice(1))
+      errorMessage = errorMessage + '\n' + indent(error.stack.split('\n').slice(1))
     }
     if (color) {
-      errorMessge = `${ansiColors.red}${errorMessge}${RESET}`
+      errorMessage = `${ansiColors.red}${errorMessage}${RESET}`
     }
     return {
       ...values,
-      message: values.message + '\n' + indent(errorMessge),
+      message: values.message + '\n' + indent(errorMessage),
     }

packages/log/src/formatters.ts-16-16 (1)

16-16: ⚠️ Potential issue | 🟡 Minor

Typo in function name: gerErrorFromLogRecord → getErrorFromLogRecord.

This appears to be an accidental rename introduced during the revert. The t is missing from get.

Proposed fix

-function gerErrorFromLogRecord(record: LogRecord): Error | null {
+function getErrorFromLogRecord(record: LogRecord): Error | null {

Also update the two call sites (lines 39 and 47):

-  const error = gerErrorFromLogRecord(record)
+  const error = getErrorFromLogRecord(record)

packages/vscode/src/node/useMcpRegistration.ts-28-28 (1)

28-28: ⚠️ Potential issue | 🟡 Minor

Non-null assertion removes the previous safety guard.

The old code checked extensionContext.value and threw a descriptive error if unavailable. The ! assertion will produce an opaque TypeError if extensionContext is ever null here. Since this is a revert PR, this is acceptable if it restores the prior state, but worth noting the loss of a clear error message.

packages/vscode/src/useWorkspaceId.ts-7-21 (1)

7-21: ⚠️ Potential issue | 🟡 Minor

JSDoc is misleading — workspace state persistence is commented out.

Line 9 claims the ID is "generated once per workspace and stored in the workspace state," but the active code on Line 21 generates a fresh ID every session (the singleton ensures once-per-session, not once-per-workspace). The commented-out code (Lines 12–20) would have implemented persistence, but it's inactive.

Either update the JSDoc to reflect reality ("generated once per extension session") or uncomment the persistence logic. Also, extensionContext (Line 4) is unused in active code since the workspace-state path is commented out.

Option A: Fix the JSDoc to match active behavior

 /**
  * Get or create a unique workspace ID. This is used to correlate the MCP server with the workspace.
- * It is generated once per workspace and stored in the workspace state.
+ * It is generated once per extension session (not persisted across sessions).
  */

packages/likec4/src/cli/export/json/handler.ts-94-98 (1)

94-98: ⚠️ Potential issue | 🟡 Minor

Edge case: all projects empty yields an empty array or undefined in the output.

If every project is skipped (empty), projectsModels has length 0 and the ternary falls through to the array branch, writing [] to the JSON file. This is silently successful, which may surprise users. Consider warning or erroring when there's nothing to export.

packages/likec4/src/cli/import/drawio/handler.ts-45-53 (1)

45-53: ⚠️ Potential issue | 🟡 Minor

Output directory is not created before writing.

If the user specifies --outfile in a directory that doesn't exist, writeFile will throw ENOENT. The sibling export handler (export/drawio/handler.ts, Line 59) calls mkdir(outdir, { recursive: true }) before writing. Consider doing the same here.

Proposed fix

+import { mkdir, readFile, writeFile } from 'node:fs/promises'
-import { readFile, writeFile } from 'node:fs/promises'

+      await mkdir(dirname(outfile), { recursive: true })
       await writeFile(outfile, likec4Source)

packages/likec4/src/cli/index.ts-23-23 (1)

23-23: ⚠️ Potential issue | 🟡 Minor

Typo: configurelogger should be configureLogger (camelCase).

The local wrapper function is named configurelogger (all lowercase) while the imported function it wraps is configureLogger. This breaks camelCase convention and is inconsistent with the import on Line 3.

Proposed fix

-function configurelogger(isDebug = isDevelopment) {
+function configureLogger_(isDebug = isDevelopment) {

Or simply rename to configureLogger if there's no shadowing concern (there is — the import has the same name). An alternative is to alias the import:

-import { configureLogger, getAnsiColorFormatter, getConsoleFormatter, getConsoleSink } from '@likec4/log'
+import { configureLogger as setupLogger, getAnsiColorFormatter, getConsoleFormatter, getConsoleSink } from '@likec4/log'

and use setupLogger inside the local function body.

apps/playground/src/components/drawio/useDrawioActions.ts-23-39 (1)

23-39: ⚠️ Potential issue | 🟡 Minor

Missing reader.onerror handler — file-read failures are silently ignored.

If FileReader.readAsText encounters an error (e.g., permission denied, file locked), no feedback is provided to the user.

Proposed fix

       const reader = new FileReader()
+      reader.onerror = () => {
+        console.error('Failed to read DrawIO file', reader.error)
+      }
       reader.onload = () => {

packages/likec4/src/cli/export/drawio/handler.ts-50-57 (1)

50-57: ⚠️ Potential issue | 🟡 Minor

Remove unsafe as ProjectId cast — validate string input properly before passing to ensureProjectId.

Line 51 casts onlyProject (a yargs string option) directly to ProjectId without validation. While ensureProjectId does validate via invariant check, relying on runtime exceptions for type safety is fragile. The cast should be replaced with proper validation, similar to the ensureProjectId helper in packages/likec4/src/cli/utils.ts that validates string paths and returns a valid ProjectId.

packages/generators/src/drawio/parse-drawio.ts-95-96 (1)

95-96: ⚠️ Potential issue | 🟡 Minor

Dead branch: styleMap.get('fillColor') can never match.

parseStyle lowercases all keys on Line 49 (k.toLowerCase()), so the map will only ever contain 'fillcolor'. The fallback ?? styleMap.get('fillColor') is dead code. Same applies to strokeColor on Line 96.

Proposed fix

-    const fillColor = styleMap.get('fillcolor') ?? styleMap.get('fillColor')
-    const strokeColor = styleMap.get('strokecolor') ?? styleMap.get('strokeColor')
+    const fillColor = styleMap.get('fillcolor')
+    const strokeColor = styleMap.get('strokecolor')

packages/generators/src/drawio/generate-drawio.ts-199-205 (1)

199-205: ⚠️ Potential issue | 🟡 Minor

Remove <mxGeometry> from the default parent cell (id="1").

The default layer cell in Draw.io should not include geometry, as it is a container, not a drawable shape. Per the mxGraph/Draw.io standard structure, id="1" is the default layer and typically has no <mxGeometry>. Including geometry may cause Draw.io to misinterpret the layer or offset child positions unexpectedly.

e2e/src/likec4-cli-build.spec.ts (1)

10-10: Nit: extra space in comment.

There's a double space before the URL.

Proposed fix

-// see  https://github.com/likec4/likec4/issues/2076
+// see https://github.com/likec4/likec4/issues/2076

packages/vscode/tsdown.config.ts (1)

112-113: process.exit(1) bypasses async cleanup; consider throwing instead.

Using process.exit(1) terminates immediately without letting tsdown's hook runner handle the failure or run any cleanup. Throwing an error would propagate naturally and still fail the build with a clear message. That said, since this is a revert PR restoring prior behavior, this is a minor nit.

♻️ Optional: throw instead of hard exit

-    console.error(`"${vscodePreview}" not found`)
-    process.exit(1)
+    throw new Error(`"${vscodePreview}" not found`)

packages/language-server/src/browser/index.ts (1)

21-22: Placeholder comment adds no value.

/* browser specific setup code */ is a vague comment with no actionable information. If this was meant as a marker for future work, a TODO with context would be clearer; otherwise, consider removing it.

Proposed cleanup

-  /* browser specific setup code */
-
   const messageReader = new BrowserMessageReader(port)

packages/language-server/src/browser/worker.ts (1)

6-9: No error handling around worker startup.

startLanguageServer(self) is invoked unconditionally with no try/catch or global error listeners. If startup fails, the worker will silently die in many browser environments, making debugging difficult. Since this is a revert to a prior known state, this is non-blocking, but worth considering for a follow-up.

Minimal error handling suggestion

-startLanguageServer(self)
+try {
+  startLanguageServer(self)
+} catch (e) {
+  console.error('Failed to start language server:', e)
+}

packages/log/src/index.ts (1)

61-61: Avoid <any, any> — use the function's own generic parameters instead.

The function already declares TSinkId and TFilterId; threading them through avoids the any escape hatch:

Proposed fix

-    configureLogtape<any, any>({
+    configureLogtape<TSinkId | 'console', TFilterId>({

As per coding guidelines, "TypeScript must use explicit types and avoid using any".

packages/vscode/src/node/mcp-server.ts (1)

39-43: Silent catch drops non-JSON LIKEC4_WORKSPACE values.

Since this is a revert, this restores the prior behavior. However, note that if LIKEC4_WORKSPACE is set to a plain path string (e.g. /home/user/project) rather than a JSON-encoded value (e.g. "\"/home/user/project\""), JSON.parse will throw and the value will be silently ignored — falling through to process.cwd() on line 49. The reverted PR (#2622) had added a fallback for this case.

If supporting plain path strings is desired, consider re-adding the fallback in a follow-up.

packages/log/src/formatters.ts (2)

87-87: Remove commented-out dead code.

This leftover comment serves no purpose and adds noise.

---

27-28: Consider using safeStringify() for non-Error values in error properties to preserve information.

In lines 27-28, when error/err properties contain non-Error values, wrapping with new Error(\${err}`)relies on template literal coercion via.toString(). For complex objects, this produces "[object Object]"and fornull/undefinedit produces"null"/"undefined", losing valuable debugging information. Using safeStringify(err, { indentation: '\t' })` (already available from the utils module) would better preserve the structure of non-Error values.

packages/likec4/src/cli/codegen/webcomponent/handler.ts (1)

76-97: Mixed logging surfaces: consola for debug/warn, logger for info.

The function now uses two different loggers — consola for debug-level and warning messages, and logger (from createLikeC4Logger) for info-level output. This split makes it harder to configure log levels consistently or filter output by source. Consider consolidating on one logger for the entire handler.

apps/playground/src/monaco/index.tsx (1)

15-15: Remove the commented-out export.

This dead comment adds no value and may confuse future readers.

🧹 Proposed fix

-// export { default as MonacoEditor } from './MonacoEditor'

packages/likec4/src/cli/export/png/handler.ts (2)

144-144: Double languageServices.languageServices is confusing.

The variable languageServices returned by fromWorkspace has a .languageServices property, making this read awkwardly. Consider aliasing to improve clarity (e.g., const lsp = languageServices.languageServices).

---

274-278: Redundant boolean: true alongside type: 'boolean' in yargs options.

Both seq and flat specify boolean: true and type: 'boolean'. One or the other suffices.

🧹 Proposed fix

           'seq': {
-            boolean: true,
             alias: ['sequence'],
             type: 'boolean',
             desc: 'use sequence layout for dynamic views',
           },
           'flat': {
             alias: ['flatten'],
-            boolean: true,
             type: 'boolean',
             desc: 'flatten all images in output directory ignoring sources structure',
           },

packages/generators/src/drawio/parse-drawio.spec.ts (1)

49-54: Edge case: the "empty" XML is structurally invalid Draw.io (no <diagram> wrapper).

The test input <mxfile><root>...</root></mxfile> omits the <diagram><mxGraphModel> wrapper that Draw.io produces. This is a fine robustness test, but consider adding a comment clarifying that it's intentionally malformed to test graceful degradation.

packages/generators/src/drawio/generate-drawio.spec.ts (1)

48-52: Mock uses unsafe double cast but works due to defensive code in generateDrawio.

The mock only provides $view, but generateDrawio also accesses $styles (lines 66, 82) and bounds (line 220). While this works at runtime because both properties are checked defensively (safe guard with '$styles' in viewmodel and try-catch for bounds), the type safety is still compromised. Adding at least the $styles property to the mock would improve type safety for future changes.

apps/playground/src/routes/w.$workspaceId/route.tsx (1)

2-3: Merge duplicate imports from the same module.

Lines 2 and 3 both import from '$components/drawio/DrawioContextMenuProvider'. Combine into a single import statement.

-import { DrawioContextMenuProvider } from '$components/drawio/DrawioContextMenuProvider'
-import { useDrawioContextMenu } from '$components/drawio/DrawioContextMenuProvider'
+import { DrawioContextMenuProvider, useDrawioContextMenu } from '$components/drawio/DrawioContextMenuProvider'

packages/generators/src/drawio/generate-drawio.ts (3)

134-142: Production code accommodates test-only position/size fields.

The getBBox helper casts to a union with position?: [number, number] and size?: { width: number; height: number } solely to support "legacy mocks." Production code shouldn't carry compatibility shims for test fixtures. Instead, fix the test mocks to use the real DiagramNode shape (x, y, width, height).

---

66-76: Fragile internal property access and bare as string casts.

'$styles' in viewmodel probes an internal/undocumented property, and values.elements.fill as string assumes a specific return shape without validation. If $styles or .colors() return type changes, this will silently produce undefined fill/stroke values baked into the XML.

Consider narrowing the type or adding a runtime check (e.g. typeof values.elements.fill === 'string').

---

124-132: Non-transitive sort comparator may produce unpredictable ordering.

The comparator returns 0 for many non-equal pairs (e.g. two nodes with different non-null parents that aren't ancestors of each other). Non-transitive comparators lead to implementation-dependent sort results. Consider a topological sort or sorting by depth first, then by parent, which guarantees parents are emitted before children.

packages/generators/src/drawio/parse-drawio.ts (3)

28-32: Low risk: regex built from name parameter — safe in current usage but fragile.

The static analysis tool flagged this as a potential ReDoS vector. All current callers pass hardcoded attribute names ('id', 'value', 'x', etc.), so there's no exploitable risk today. However, if a future caller passes untrusted input, the unescaped name could break the regex or enable ReDoS.

Consider escaping name or switching to a simple indexOf/slice approach:

Alternative: indexOf-based extraction

 function getAttr(attrs: string, name: string): string | undefined {
-  const re = new RegExp(`${name}="([^"]*)"`, 'i')
-  const m = attrs.match(re)
-  return m ? m[1] : undefined
+  const search = `${name}="`
+  const idx = attrs.toLowerCase().indexOf(search.toLowerCase())
+  if (idx < 0) return undefined
+  const start = idx + search.length
+  const end = attrs.indexOf('"', start)
+  return end > start ? attrs.slice(start, end) : undefined
 }

---

293-300: Every element without children/desc/tech/color gets an empty block.

When hasBody is false, the code emits an empty { } block (Lines 296–297). This produces noisy output like:

  myElement = container 'My Element'
  {
  }

Consider omitting the block entirely for leaf elements with no metadata.

Proposed fix

     } else {
-      lines.push(`${pad}{`)
-      lines.push(`${pad}}`)
+      // No body needed — omit empty block
     }

---

72-72: Unnecessary indirection: geomAttr is just an alias for getAttr.

const geomAttr = (tag: string, name: string) => getAttr(tag, name) adds a wrapper that does nothing. Use getAttr directly on Lines 91–94.