Refactor review feedback: consolidate include paths, improve node lookup semantics#2430
Merged
davydkov merged 2 commits intokieron/shared-filesfrom Dec 6, 2025
Merged
Refactor review feedback: consolidate include paths, improve node lookup semantics#2430davydkov merged 2 commits intokieron/shared-filesfrom
davydkov merged 2 commits intokieron/shared-filesfrom
Conversation
Merged
7 tasks
Co-authored-by: davydkov <[email protected]>
Copilot
AI
changed the title
[WIP] Add include configuration option to LikeC4 project
Refactor review feedback: consolidate include paths, improve node lookup semantics
Dec 6, 2025
davydkov
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbefore creating this PR.Description
Addresses review feedback on PR #2425 to improve type safety and API semantics.
Key Changes
ProjectData includePaths consolidation – Merged separate
includePaths: URI[]andincludePathsAsStrings: ProjectFolder[]arrays into single structure:Eliminates possibility of arrays getting out of sync and reduces cognitive overhead.
Node lookup semantics – Renamed
findNodeByElementFqntofindNodeByModelFqnand changed return type fromNodeId | nullto enriched node object:Callers now get full node with guaranteed
modelFqnproperty instead of just ID string.Auto-unfocus timing – Changed
AUTO_UNFOCUS_DELAYfrom0to3000ms. Previous value made conditional check always false, disabling intended behavior.Test cleanup – Removed autogenerated test file with no actual assertions.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.