Skip to content

refactor: replace deprecated Zod .nonempty() with .min(1)#2426

Merged
davydkov merged 2 commits intokieron/shared-filesfrom
copilot/sub-pr-2425
Dec 5, 2025
Merged

refactor: replace deprecated Zod .nonempty() with .min(1)#2426
davydkov merged 2 commits intokieron/shared-filesfrom
copilot/sub-pr-2425

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 5, 2025

Description

Addresses code review feedback from #2425 to replace deprecated Zod .nonempty() method with .min(1) for forward compatibility with Zod v3.23+.

Updated three schema files in packages/config/src/:

  • schema.include.ts - Include path validation
  • schema.image-alias.ts - Image alias value validation
  • schema.theme.ts - Color name and color value validation (2 occurrences)

Before:

const value = z.string().nonempty('Value cannot be empty')

After:

const value = z.string().min(1, 'Value cannot be empty')

Checklist

  • I've thoroughly read the latest contribution guidelines.
  • I've rebased my branch onto main before creating this PR.
  • My commit messages follow conventional spec
  • I've added tests to cover my changes (if applicable).
  • I've verified that all new and existing tests have passed locally for mobile, tablet, and desktop screen sizes.
  • My change requires documentation updates.
  • I've updated the documentation accordingly.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Address feedback on shared files configuration implementation refactor: replace deprecated Zod .nonempty() with .min(1) Dec 5, 2025
Copilot AI requested a review from kieronlanning December 5, 2025 01:15
@davydkov davydkov marked this pull request as ready for review December 5, 2025 03:55
@davydkov davydkov merged commit 0a61bec into kieron/shared-files Dec 5, 2025
17 checks passed
@davydkov davydkov deleted the copilot/sub-pr-2425 branch December 5, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants