Conversation
…een and SearchListDetailScreen
…nd ComponentDetailViewModel
lihenggui
reviewed
Mar 20, 2025
lihenggui
reviewed
Mar 20, 2025
lihenggui
reviewed
Mar 21, 2025
lihenggui
reviewed
Mar 23, 2025
…d visible for testing" This reverts commit 0a05cf7.
lihenggui
approved these changes
Mar 24, 2025
Goooler
reviewed
Mar 25, 2025
| val unselectedIcon: ImageVector, | ||
| val iconTextId: Int, | ||
| val titleTextId: Int, | ||
| val route: KClass<*>, |
Contributor
There was a problem hiding this comment.
The TopLevelDestination looks could be treated as route type, no need to add an extra route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
label: 'triage me'
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
we can discuss the change, evaluate designs, and agree on the general idea
pass (
./gradlew --init-script gradle/init.gradle.kts spotlessApplyto automatically applyformatting)
Is this your first Pull Request?
./tools/setup.shFixes #<issue_number_goes_here> 🦕