Skip to content

build: update to version of btcd with wire parsing bug fix#7004

Merged
Roasbeef merged 2 commits into
lightningnetwork:masterfrom
Roasbeef:witness-limit-hot-fix
Oct 10, 2022
Merged

build: update to version of btcd with wire parsing bug fix#7004
Roasbeef merged 2 commits into
lightningnetwork:masterfrom
Roasbeef:witness-limit-hot-fix

Conversation

@Roasbeef

@Roasbeef Roasbeef commented Oct 10, 2022

Copy link
Copy Markdown
Member

Fixes #7002

@otech47 otech47 mentioned this pull request Oct 10, 2022
Closed
sangaman
sangaman approved these changes Oct 10, 2022
View reviewed changes

@sangaman sangaman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pulled this branch and compiled off of it and tried running lnd on testnet, my synced_to_chain went from false to true and I'm able to send on-chain transactions.

@Roasbeef

Roasbeef commented Oct 10, 2022

Copy link
Copy Markdown
Member Author

@sangaman thanks for testing things out! This PR can be applied for those already on master. For those that are running 0.15.0 or 0.15.1, we'll be cherry picking this PR onto a new 0.15.2 release (branched off from 0.15.1) which'll backport the fix.

@kaloudis

kaloudis commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

tACK

my node is back up

@pinheadmz

pinheadmz commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

tACK, working here as well on arm with bitcoind full node backend

@Roasbeef

Roasbeef commented Oct 10, 2022

Copy link
Copy Markdown
Member Author

Ok, the btcd version bump PR has landed, with a corresponding release there: https://github.com/btcsuite/btcd/releases/tag/v0.23.2

Now I can update this PR to point to that release rather than my fork.

@Roasbeef Roasbeef force-pushed the witness-limit-hot-fix branch from e168683 to 1c88484 Compare October 10, 2022 01:40
kajoseph
kajoseph approved these changes Oct 10, 2022
View reviewed changes

@kajoseph kajoseph left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK with:

  • testnet on Linux 5.4.0-125-generic #141-Ubuntu SMP Wed Aug 10 13:42:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • mainnet on Linux 5.4.0-125-generic #141-Ubuntu SMP Wed Aug 10 13:42:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • mainnet on Linux 5.10.103-v8+ #1529 SMP PREEMPT Tue Mar 8 12:26:46 GMT 2022 aarch64 GNU/Linux

@pcharest

pcharest commented Oct 10, 2022

Copy link
Copy Markdown

tACK on windows 10

@Roasbeef Roasbeef merged commit 406fc86 into lightningnetwork:master Oct 10, 2022
@seth586

seth586 commented Oct 10, 2022

Copy link
Copy Markdown

tACK FreeBSD 13.1-RELEASE-p1 amd64

This was referenced Oct 10, 2022
Merged
Merged
@MaxKotlan MaxKotlan mentioned this pull request Oct 10, 2022
Merged
@okeygo

okeygo commented Oct 10, 2022

Copy link
Copy Markdown

Patch applied, working fine now.

2022-10-10 09:03:32.280 [INF] UTXN: Attempting to graduate height=757997: num_kids=0, num_babies=0
2022-10-10 09:03:32.749 [INF] CRTR: Block 00000000000000000004d70d2fb15f406887046220cea70f69225c451251d998 (height=758000) closed 1 channels
2022-10-10 09:03:32.749 [INF] CRTR: Pruning channel graph using block 000000000000000000076b936c0265aa70ba1d9aca08e41f833ce15e8a129f09 (height=758001)
2022-10-10 09:03:32.805 [INF] NTFN: New block: height=757998, sha=000000000000000000058c270b8230d767869edc757ba964be8a7456123aab20
2022-10-10 09:03:32.805 [INF] UTXN: Attempting to graduate height=757998: num_kids=0, num_babies=0
2022-10-10 09:03:33.200 [INF] CRTR: Block 000000000000000000076b936c0265aa70ba1d9aca08e41f833ce15e8a129f09 (height=758001) closed 1 channels
2022-10-10 09:03:33.272 [INF] NTFN: New block: height=757999, sha=00000000000000000002189e962a78e1cdbfc70bdb7282615413bc499b605078
2022-10-10 09:03:33.273 [INF] UTXN: Attempting to graduate height=757999: num_kids=0, num_babies=0
2022-10-10 09:03:33.630 [INF] NTFN: New block: height=758000, sha=00000000000000000004d70d2fb15f406887046220cea70f69225c451251d998
2022-10-10 09:03:33.630 [INF] UTXN: Attempting to graduate height=758000: num_kids=0, num_babies=0
2022-10-10 09:03:34.022 [INF] NTFN: New block: height=758001, sha=000000000000000000076b936c0265aa70ba1d9aca08e41f833ce15e8a129f09
2022-10-10 09:03:34.022 [INF] UTXN: Attempting to graduate height=758001: num_kids=0, num_babies=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sangaman sangaman sangaman approved these changes
@kajoseph kajoseph kajoseph approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug]: Fail to chain sync on testnet3 & mainnet errors relating to: script witness item is larger than the max allowed size

8 participants

@Roasbeef @kaloudis @pinheadmz @pcharest @seth586 @okeygo @sangaman @kajoseph