REST saga 2/3: Add REST endpoints to all RPCs#4251
Merged
Conversation
This was referenced May 6, 2020
Member
|
First part in, can be rebased now. |
Roasbeef
requested changes
May 12, 2020
Roasbeef
left a comment
Roasbeef
left a comment
Member
There was a problem hiding this comment.
Mainly some commentary w.r.t the new REST paths
Member
|
Ready to leave draft now? |
guggero
force-pushed
the
rest-2-subservers
branch
from
c38ab56 to
748889a
Compare
guggero
changed the title
guggero
force-pushed
the
rest-2-subservers
branch
2 times, most recently
from
db7e6e7 to
e2b0a6b
Compare
Roasbeef
approved these changes
May 27, 2020
Roasbeef
left a comment
Roasbeef
left a comment
Member
There was a problem hiding this comment.
LGTM 🎊
Really nice to have all these gaps filled. There's an upcoming informal meeting amongst a lot of lnd users, so we might want to hold off on merging this until we get some of their feedback w.r.t name-spacing. Alternatively, we can merge this early then follow up with feedback later, given we'll need to bundle this with a release ultimately.
guggero
force-pushed
the
rest-2-subservers
branch
from
e2b0a6b to
11065a4
Compare
guggero
force-pushed
the
rest-2-subservers
branch
from
11065a4 to
51870ba
Compare
Collaborator
Author
|
Reworked the PR to implement the suggestion in #4329 and added a very simple check to |
guggero
force-pushed
the
rest-2-subservers
branch
from
9b99481 to
19e3dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of 3 of the REST improvement saga which will ultimately replace #4141:
WalletUnlockerinto own file, generate Swagger docs for all RPCs, fix comment styles (replace///with//and/**with/*).grpc-gatewaycode to all subservers and updategrpc-gatewaylibrary.Fixes #4329.