REST saga 3/3: REST API for subservers, websocket for streaming responses#4141
Conversation
dbfeff0 to
be034ad
Compare
be034ad to
e17cbc5
Compare
e17cbc5 to
7315f73
Compare
5fdd6ef to
56af0e1
Compare
56af0e1 to
28581be
Compare
|
Hey Guggero, I started trying out some of the endpoints tonight. I may have found some quirks that can help with the process. POST /v2/wallet/address/next This next endpoint is the big one everyone is probably eager to use I was splitting along the newline to watch as it tried the attempts: I also tried out: GET /v2/router/htlcevents POST /v2/router/send return data:
|
|
@sako0938 thank you very much for testing!
I don't think sending an empty POST worked before that PR. Or maybe it changed because of the library update. But in any case, a POST body always has to be set. If there's no content to send, just send a
That's exactly why WebSockets are needed, because there are multiple messages being returned that are valid JSON each on its own. Adding WebSocket support is the whole point of this PR (while adding the REST endpoints was done in PR 2/3). So please test again with a WS library (code examples can be found in the preview of the API doc: https://www.guggero.org/lightning-api/#v2-router-send)
Was I referring to this PR specifically? Maybe there was a misunderstanding. They should work now :) |
28581be to
1fde724
Compare
1fde724 to
e86d73d
Compare
e86d73d to
1cda467
Compare
…ements REST saga 3/3: REST API for subservers, websocket for streaming responses
This is part 3 of 3 of the REST improvement saga which will ultimately replace #4141:
WalletUnlockerinto own file, generate Swagger docs for all RPCs, fix comment styles (replace///with//and/**with/*).grpc-gatewaycode to all subservers and updategrpc-gatewaylibrary.Depends on #4251, only the last 4 commits are new.
Updated API docs for unified gRPC/REST APIs can be previewed here.
Fixes #3622
Fixes #4222
Fixes #2344
Fixes #2730
Fixes #4100
Fixes #4229
Fixes #3430