multi: stop using lnwire.WriteElement #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move WriteElement[s] to the codec package so that packages other than clientdb can use it. For the codec package, we avoid depending on other packages within Pool so that no circular dependencies develop. This requires us to move some of the uintXX casting logic in clientdb/codec.go to call sites.
There are plans to remove lnwire.WriteElement entirely from LND in favor of the faster statically-typed encoding functions. Switch to using those faster functions.
Return directly when possible, rather than falling through to return nil.
morehouse
force-pushed
the
lnwire_static_type_writes
branch
from
b5f444a to
f7c711b
Compare
ffranr
approved these changes
May 17, 2023
Contributor
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the well organised commit structure 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to eventually remove
lnwire.WriteElementfrom LND in favor of the faster statically-typed write functions. Switch to using those faster functions in Pool.Requested by @guggero on lightningnetwork/lnd#7690.
Pull Request Checklist
used.