account recovery: increase default number of keys to try #436
Conversation
This commit fixes an issue where a large number of attempts at creating an account lead to the index of the first successful account to be higher than the previous number of keys we tried by default. This resulted in the account not being recovered without manually overriding this value in the command line.
This commit fixes an issue where the derivation index of an account was greater than the default number of keys we attempted during account recovery.
| RUN apt-get update && apt-get install -y git | ||
| ENV GOCACHE=/tmp/build/.cache | ||
| ENV GOMODCACHE=/tmp/build/.modcache | ||
| ENV GOFLAGS="-buildvcs=false" |
There was a problem hiding this comment.
should we add it to the dockerfile in the same way that is done in the other projects?
There was a problem hiding this comment.
Do you mean the git config --global --add safe.directory /build? (We fixed it a number of times, not sure which one actually fixes what).
To be hones, this seems clearer as it directly fixes the issue and makes it more clear that it's a Golang issue (that might be fixed in the future), rather than implying it was some sort of git problem. I can go ahead and fix it in all other repos in this manner.
There was a problem hiding this comment.
fixes the issue and makes it more clear that it's a Golang related issue 🥇
Do not fix it in all the other repos, I will change them and tag you in the PR 👍
Fixes lightninglabs/lightning-terminal#470.
Pull Request Checklist
used.