docker: perform dependencies installation in separate run layer #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit separates the task of dependencies installation into its own separate run layer. Previously, dependencies installation shared the same layer as local repo build. This change means that the dependencies run layer can be reused (cached) whilst the local repo is modified. Which is helpful for regtests.
guggero
approved these changes
Nov 15, 2022
positiveblue
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit separates the task of dependencies installation into its own separate run layer. Previously, dependencies installation shared the same layer as local repo build.
This change means that the dependencies run layer can be reused (cached) whilst the local repo is modified. Which is helpful for regtests.
I've tested this change by building the docker image.
Pull Request Checklist
used.