Skip to content

Conversation

@positiveblue
Copy link
Contributor

Bonus: log returned errors by lnd when canceling a shim.

Fix #405

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

"announced or unannounced channels. Set to 1 " +
"for only announced channels and 2 for only " +
"announced or unannounced channels. Set to 0 " +
"to express no preference, set to 1 for " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double space.

@positiveblue positiveblue merged commit c71a9c3 into lightninglabs:master Nov 7, 2022
@C-Otto
Copy link

C-Otto commented Dec 4, 2022

You updated the announcement_constraints, not the confirmation_constraints. When I try to create a channel that accepts 0 conf, I still don't see how to do that in the CLI -h output, nor in the confirmation summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outbound ask order: allow any confirmation constraint

4 participants