cmd: allow min_chan_amt > amt for outbound liquidity orders
#406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
requested changes
Nov 1, 2022
cmd/pool/order.go
Outdated
Comment on lines
213
to
216
| // parseMinChanAmount parses and validates the value for the `min_chan_amt` | ||
| // parameter. | ||
| func parseMinChanAmount(ctx *cli.Context, amt uint64) (btcutil.Amount, error) { | ||
| minChanAmt := btcutil.Amount(ctx.Uint64("min_chan_amt")) |
Contributor
There was a problem hiding this comment.
I don't think this function does much parsing of min_chan_amt. It might be a good idea if this function was
validateMinChanAmount(minChanAmount btcutil.Amount, amt btcutil.Amount, auctionType) error
and move the getMinChanAmount functionality into a separate function. I think it would make more sense that a validator accepts amt as an argument. And testing might be simpler.
positiveblue
force-pushed
the
fix-402
branch
5 times, most recently
from
bdf41e5 to
a26a812
Compare
ffranr
approved these changes
Nov 7, 2022
Contributor
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
Looks good! Nice refactoring.
I've only read the code. Let me know if I should do more.
Skip the extra check in the cli validation flow for the markets where this option is a valid. This bug only applied to the validation logic in the cli package, poold and the backend services validate the orders correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the extra check in the cli validation flow for the markets where this option is a valid.
This bug only applied to the validation logic in the cli package, poold and the backend services validate the orders correctly.