cmd: improve InitAccount cli message #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our message was really confusing. If InitAccount was used with the `sat_per_vbyte` option we were printing the default `conf_target` that was not used at all.
Roasbeef
approved these changes
Mar 3, 2022
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
LGTM 🦗
Thx for the quick fix here!
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
Extend account that are close to expiry after (sucessfully) participating in a batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our message was really confusing. If
sat_per_vbytewas provided, Init account was printing aconf_targetthat was not used at all.