Conditional batch version for itests #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
approved these changes
Dec 21, 2021
Contributor
positiveblue
left a comment
positiveblue
left a comment
There was a problem hiding this comment.
LGTM, this will make testing/debugging easier.
To make sure the CurrentBatchVersion isn't used anywhere as the default version anymore by accident, we explicitly rename it.
guggero
force-pushed
the
conditional-batch-version
branch
from
63294ea to
cd3b6b6
Compare
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
…aper-retry-refactor Bos score scraper retry refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the batch version configurable to enable integration testing of different client batch versions in the same batch.
Pull Request Checklist
used.