Fix compatibility issues with Pool #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still require the helper function EstimateFeeToP2WSH in Pool. Rather than to add a new wrapper to each project that still relies on the old method, we add the backward compatible wrapper to the client directly.
We use go mocks in Pool. Apparently that tool has trouble parsing imported packages in the length part of an array. Since fixing the tool isn't trivial, it's easier to hard code the value here (since the length isn't expected to ever change).
bhandras
approved these changes
Jun 1, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes a problem found with the mocking library we use in Pool. And we also add back the
EstimateFeeToP2WSHconvenience method, since that's still used in some projects.in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.