multi: bump lnd+lndclient compile time dependency #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Shall we also bump the minimum lnd version to 0.15.99? |
Contributor
Author
I don't think we added anything that requires runtime compatibility. So |
Member
|
Shall we merge this given rc1 is out? |
Contributor
Author
|
Integration test seems to be flaky, it did complete on my machine. Kicked it again, let's see. |
positiveblue
approved these changes
Feb 27, 2023
Contributor
positiveblue
left a comment
positiveblue
left a comment
There was a problem hiding this comment.
The second commit says v1.19.2 but we bump golang to v1.19.4
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compile time compatibility with lnd 0.16.
Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.