multi: use lndclient MacaroonService #140
Conversation
ellemouton
force-pushed
the
macaroonService
branch
2 times, most recently
from
c81b3b9 to
5b1ae63
Compare
|
Tested this and seems to work well with upgrading/changing the password. This also causes the itest to fail: Not sure if this is a problem, @carlaKC ? If it is, we could say that since Faraday does read only stuff only (currently), encrypting the macaroon DB isn't as important as in the other daemons? |
I think it's ok to just switch over to needing write permissions for this purpose? If we update the docs accordingly, shouldn't be an issue. |
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
I think it's ok to just switch over to needing write permissions for this purpose? If we update the docs accordingly, shouldn't be an issue.
Okay, cool. Just wanted to let you know in case there are complaints later on...
@ellemouton seems like this requires a small change in the itest to no longer use the readonlym.macaroon. And we should also update the docs where necessary.
ellemouton
force-pushed
the
macaroonService
branch
2 times, most recently
from
e99db80 to
273594b
Compare
|
updated 👍 thanks for catching! |
ellemouton
force-pushed
the
macaroonService
branch
from
273594b to
da7ffb8
Compare
|
Argh, another PR that fell off the radar, sorry. Can you rebase please? Then this can get in before #147. |
ellemouton
force-pushed
the
macaroonService
branch
3 times, most recently
from
714aa15 to
7fe36ec
Compare
Since the code for creating and using a macaroon service is the same for multiple projects (pool, loop, faraday & litd), the code has been unified in lndclient. So this commit removes the macaroon service code and instead uses the lndclient code. Since the default key for the macaroon db is now a shared secret with LND, faraday requires LND's admin macaroon so that this secret can be derived. So this commit also updates all references of LND's `readme` macaroon to the `admin` macaroon.
Rename createDefaultMacaroonFile to withMacaroonService since this is now a more appropriate name.
ellemouton
force-pushed
the
macaroonService
branch
from
7fe36ec to
00a8a39
Compare
|
rebased :) |
This fixes a small oversight in #140 where we forgot to also _create_ the macaroon service in the StartAsSubserver() method.
This fixes a small oversight in #140 where we forgot to also _create_ the macaroon service in the StartAsSubserver() method.
|
This was unfortunate... Edit: when bumping the newest master, I discovered that now admin.macaroon is needed. This issue reverts #84 (not technically, but in spirit) |
4 participants
Since the code for creating and using a macaroon service is the same for
multiple projects (pool, loop, faraday & litd), the code has been
unified in lndclient. So this commit removes the macaroon service code
and instead uses the lndclient code.
Depends on lightninglabs/lndclient#86