Repository navigation
fix(claude): expose native Fast selectors with 1M context - #7748
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration into
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Merged into
devby @lidge-jun on 2026-10-27 at 18:49:50 UTC (2026-10-28 03:49:50 KST). Merge commit:0c32c8132d0fd2731e8f772aac1b62874e8041a0.[1m],--fast, and--fast[1m], for readable Claude Code IDs and hashed Desktop discovery IDs. The combined row is labelled· Fast · 1Mand preserves the native input ceiling.devand addedtests/claude-integration/claude-native-fast-1m-ingress.test.tsbefore integration. The original contributor commit remains attributed to @jbamlee.Verification
Final PR head:
c1584c07a05b6b3af0c8e7675b6d6d676ece03b9.cicheck. Platform jobs skipped by PR policy are not claimed as tested.[1m]picker rows remains an unverified, non-blocking follow-up in the maintainer record. No live upstream capacity claim or shared-installation deployment is made here.Historical contributor validation on 2026-10-26 — original head 2c42324
Candidate
2c42324f97fd07859babedeff03efb724b778738, rebased ontodevat8dd330a3f5165ea1685ad5282c5215a56dbc09f2. Local validation used macOS arm64 and repository-pinned Bun 1.4.4.node_modules/.bin/bun run test \ tests/codex-integration/fast-row-listing.test.ts \ tests/claude-integration/claude-model-info.test.ts \ tests/claude-integration/claude-long-context-eligibility.test.ts \ tests/providers/fast-row-ingress.test.ts \ tests/claude-integration/claude-models-discovery.test.ts \ tests/claude-integration/claude-gateway-cache.test.ts \ tests/claude-integration/claude-messages-endpoint.test.ts \ tests/codex-integration/fast-row.test.ts \ tests/providers/cursor/cursor-fast-listing.test.tsnode_modules/.bin/bun run typecheck,node_modules/.bin/bun run structure:check,node_modules/.bin/bun run privacy:scan,node_modules/.bin/bun scripts/file-size-ratchet.ts, andgit diff --check upstream/dev...HEAD.cd docs-site && ../node_modules/.bin/bun install --frozen-lockfile && ../node_modules/.bin/bun run build— 593 pages and 84,893 internal links checked.node_modules/.bin/bun run test:changed— 3,582 passed, 30 skipped, one failed across 175 files.loopback companion listener > binds 127.0.0.1 on the public port, and only loopback is credential-freefails attests/server/loopback-listener-integration.test.ts:1082withECONNREFUSEDon the host-selected non-loopback interface. It reproduces at the same assertion with the sole production change reverted toupstream/dev; all production files then match the base. The candidate was restored and its original fingerprint verified. Baseline reproduction command:Before the fix, the new focused cases produced three missing-combination failures. Independent review used gpt-6-astra, xhigh, with no material findings. Its five file hashes and patch fingerprint remain identical after the clean rebase; the upstream effort-clamp change was inspected and the affected focused tests passed on the rebased candidate.
FULL SUITE COMPLETED, NOT GREEN:
node_modules/.bin/bun run teston the same head completed with exit 1: 52,690 passed, 170 skipped, three failed across 2,617 files (22 runner lanes, approximately 7m53s). All three failing cases also reproduce with the sole production hunk reverted toupstream/dev. This is baseline-reproducible failure evidence, not a passing full suite or permission to expand this native discovery fix.Two additional full-suite failures are in
tests/config/serving-runtimes.test.ts:a real child that marks bind propagates a later nonzero exit(expected 42, received null), anda delegated child receives the parent's SIGTERM and its status survives(expected 0 or 143, received null).node_modules/.bin/bun run test tests/config/serving-runtimes.test.tsproduced 34 pass / 2 fail both on the candidate and with all production files matchingupstream/dev. The candidate bytes were restored and verified. No service/runtime repair is included.No actual Claude Code/Desktop UI selection, real upstream Fast inference, or large-context capacity test was performed. The local HTTP test proves discovery only. Shared installation and services remain unchanged.
Historical external approval blocker on 2026-10-26 (subsequently resolved): Cross-platform CI and Catalog async contracts show “awaiting approval from a maintainer,”
action_required, and zero jobs. The author account has upstreamREADaccess (push,maintain, andadminare false), so it cannot approve these workflows. PR Labeler and PR hygiene are pending; the target/readiness workflow is queued. No CI success is claimed.Review status: zero submitted upstream reviews and zero unresolved review threads. CodeRabbit explicitly skipped the draft; its green status is not a completed review. No new material review finding is available to repair. The existing independent
gpt-6-astra/xhighreview remains tied to identical file fingerprints.At the contributor checkpoint, the branch was on that day's
devtip (zero commits behind). The original contributor readiness checklist was left at 1/4; it was not retroactively marked complete. At that checkpoint, the PR remained draft. CI execution approval and maintainer code review are separate states.Exact-head validation evidence excerpts
The separately reproduced listener baseline fails at
loopback-listener-integration.test.ts:1082withECONNREFUSEDbefore the expected HTTP 401. This request has no Anthropic discovery header or flavor and does not select the changed model-info builder. The three baseline findings remain outside this PR's repair scope; they are not dismissed as passing tests.Checklist
Historical readiness checklist — superseded by maintainer integration
Review readiness checklist
Historical automation template: this PR is already merged under the documented maintainer-integration exception. These boxes are not retroactive author attestations and do not describe an active draft.
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.