Skip to content

fix(claude): expose native Fast selectors with 1M context - #7748

Merged
lidge-jun merged 3 commits into
lidge-jun:devfrom
jbamlee:jbamlee/native-fast-1m-pr
Oct 27, 2026
Merged

lidge-jun merged 3 commits into
lidge-jun:devfrom
jbamlee:jbamlee/native-fast-1m-pr

Conversation

@jbamlee

@jbamlee jbamlee commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Merged into dev by @lidge-jun on 2026-10-27 at 18:49:50 UTC (2026-10-28 03:49:50 KST). Merge commit: 0c32c8132d0fd2731e8f772aac1b62874e8041a0.

  • Native OpenAI models that qualify for both Fast and long-context discovery now expose four choices: base, [1m], --fast, and --fast[1m], for readable Claude Code IDs and hashed Desktop discovery IDs. The combined row is labelled · Fast · 1M and preserves the native input ceiling.
  • The fix composes the existing Fast and 1M projections inside the native loop. Routed-provider enumeration, tier policy, capacities, and compaction policy remain unchanged; no configuration or dependencies were added.
  • The maintainer brought the branch onto dev and added tests/claude-integration/claude-native-fast-1m-ingress.test.ts before integration. The original contributor commit remains attributed to @jbamlee.

Verification

Final PR head: c1584c07a05b6b3af0c8e7675b6d6d676ece03b9.

  • Cross-platform CI completed successfully on the final head before merge, including Ubuntu test shards 1/4–4/4 and the aggregate ci check. Platform jobs skipped by PR policy are not claimed as tested.
  • Catalog async contracts and Enforce PR target branch also passed on the final head before merge.
  • The maintainer integration record documents the added ingress regression, independent review, merged-tree validation, and the repository's maintainer-integration exception. Maintainer validation superseded the original contributor readiness checklist; that checklist was not retroactively ticked.
  • Automated review completion is separate: the Codex review job failed to complete after merge, and CodeRabbit stopped because the PR was closed. These are not test-CI failures or completed reviews. No inline review findings or linked closing issues are present.
  • Actual Claude Desktop acceptance of hashed [1m] picker rows remains an unverified, non-blocking follow-up in the maintainer record. No live upstream capacity claim or shared-installation deployment is made here.
Historical contributor validation on 2026-10-26 — original head 2c42324

Candidate 2c42324f97fd07859babedeff03efb724b778738, rebased onto dev at 8dd330a3f5165ea1685ad5282c5215a56dbc09f2. Local validation used macOS arm64 and repository-pinned Bun 1.4.4.

  • PASS: 178 tests across nine focused files, including actual loopback HTTP discovery, readable/hashed IDs, both eligibility rules, input ceilings, parser/endpoint/cache behavior, and representative routed Fast behavior:
node_modules/.bin/bun run test \
  tests/codex-integration/fast-row-listing.test.ts \
  tests/claude-integration/claude-model-info.test.ts \
  tests/claude-integration/claude-long-context-eligibility.test.ts \
  tests/providers/fast-row-ingress.test.ts \
  tests/claude-integration/claude-models-discovery.test.ts \
  tests/claude-integration/claude-gateway-cache.test.ts \
  tests/claude-integration/claude-messages-endpoint.test.ts \
  tests/codex-integration/fast-row.test.ts \
  tests/providers/cursor/cursor-fast-listing.test.ts
  • PASS: node_modules/.bin/bun run typecheck, node_modules/.bin/bun run structure:check, node_modules/.bin/bun run privacy:scan, node_modules/.bin/bun scripts/file-size-ratchet.ts, and git diff --check upstream/dev...HEAD.
  • PASS: cd docs-site && ../node_modules/.bin/bun install --frozen-lockfile && ../node_modules/.bin/bun run build — 593 pages and 84,893 internal links checked.
  • NOT GREEN: node_modules/.bin/bun run test:changed — 3,582 passed, 30 skipped, one failed across 175 files. loopback companion listener > binds 127.0.0.1 on the public port, and only loopback is credential-free fails at tests/server/loopback-listener-integration.test.ts:1082 with ECONNREFUSED on the host-selected non-loopback interface. It reproduces at the same assertion with the sole production change reverted to upstream/dev; all production files then match the base. The candidate was restored and its original fingerprint verified. Baseline reproduction command:
node_modules/.bin/bun run test tests/server/loopback-listener-integration.test.ts \
  -t 'binds 127.0.0.1 on the public port, and only loopback is credential-free'
  • Before the fix, the new focused cases produced three missing-combination failures. Independent review used gpt-6-astra, xhigh, with no material findings. Its five file hashes and patch fingerprint remain identical after the clean rebase; the upstream effort-clamp change was inspected and the affected focused tests passed on the rebased candidate.

  • FULL SUITE COMPLETED, NOT GREEN: node_modules/.bin/bun run test on the same head completed with exit 1: 52,690 passed, 170 skipped, three failed across 2,617 files (22 runner lanes, approximately 7m53s). All three failing cases also reproduce with the sole production hunk reverted to upstream/dev. This is baseline-reproducible failure evidence, not a passing full suite or permission to expand this native discovery fix.

  • Two additional full-suite failures are in tests/config/serving-runtimes.test.ts: a real child that marks bind propagates a later nonzero exit (expected 42, received null), and a delegated child receives the parent's SIGTERM and its status survives (expected 0 or 143, received null). node_modules/.bin/bun run test tests/config/serving-runtimes.test.ts produced 34 pass / 2 fail both on the candidate and with all production files matching upstream/dev. The candidate bytes were restored and verified. No service/runtime repair is included.

  • No actual Claude Code/Desktop UI selection, real upstream Fast inference, or large-context capacity test was performed. The local HTTP test proves discovery only. Shared installation and services remain unchanged.

  • Historical external approval blocker on 2026-10-26 (subsequently resolved): Cross-platform CI and Catalog async contracts show “awaiting approval from a maintainer,” action_required, and zero jobs. The author account has upstream READ access (push, maintain, and admin are false), so it cannot approve these workflows. PR Labeler and PR hygiene are pending; the target/readiness workflow is queued. No CI success is claimed.

  • Review status: zero submitted upstream reviews and zero unresolved review threads. CodeRabbit explicitly skipped the draft; its green status is not a completed review. No new material review finding is available to repair. The existing independent gpt-6-astra / xhigh review remains tied to identical file fingerprints.

  • At the contributor checkpoint, the branch was on that day's dev tip (zero commits behind). The original contributor readiness checklist was left at 1/4; it was not retroactively marked complete. At that checkpoint, the PR remained draft. CI execution approval and maintainer code review are separate states.

Exact-head validation evidence excerpts
Head: 2c42324f97fd07859babedeff03efb724b778738
Runtime: Bun 1.4.4; macOS arm64
Full parallel lane: 51,952 pass / 147 skip / 3 fail (2,596 files)
21 isolated runner lanes combined: 738 pass / 23 skip / 0 fail
Total: 52,690 pass / 170 skip / 3 fail (2,617 files); exit 1

serving-runtimes.test.ts, candidate isolated: 34 pass / 2 fail; exit 1
serving-runtimes.test.ts, upstream/dev production baseline: 34 pass / 2 fail; exit 1

The separately reproduced listener baseline fails at loopback-listener-integration.test.ts:1082 with ECONNREFUSED before the expected HTTP 401. This request has no Anthropic discovery header or flavor and does not select the changed model-info builder. The three baseline findings remain outside this PR's repair scope; they are not dismissed as passing tests.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. No security-boundary code or dependency changes; the contributor privacy scan passed.
Historical readiness checklist — superseded by maintainer integration

Review readiness checklist

Historical automation template: this PR is already merged under the documented maintainer-integration exception. These boxes are not retroactive author attestations and do not describe an active draft.

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked.

Hygiene

✅ Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun marked this pull request as ready for review October 27, 2026 18:49
@lidge-jun

Copy link
Copy Markdown
Owner

Maintainer integration into dev (MAINTAINERS.md, maintainer-integration exception).

  • Exact head: c1584c07a05b6b3af0c8e7675b6d6d676ece03b9 (contributor commits plus a maintainer merge of dev and a maintainer ingress regression, tests/claude-integration/claude-native-fast-1m-ingress.test.ts, which proves readable and Desktop --fast[1m] selectors reach the native upstream with service_tier: "priority" and fails if the Fast decode is removed).
  • Exact-head CI: Cross-platform CI run 40531659960 (gates, test 1/4..4/4, structure gate, storage policy, api usage, docker smoke, docs site build, npm-global, ci: all success), Catalog async contracts 40531659896, Enforce PR target branch 40531655489, PR hygiene 40531656138, labeler 40531656311: success.
  • Independent review (GPT-6.1 Sol): round 1 raised one verification gap (actual Claude Code picker acceptance); round 2 PASS with 0 blocking findings after a static client-contract check of the published @anthropic-ai/claude-code packages: on 2.1.257 and 2.1.311 the readable combined selector is listed as a distinct entry and sent as <id>--fast with the context-1m-2025-08-07 beta. Non-blocking follow-up: Claude Desktop client acceptance of hashed [1m] rows is unverified; this applies equally to the existing hashed [1m] rows.
  • Union with current dev (95cfa30): clean merge; file-size ratchet, layout guards and the affected tests pass on the merged tree (50 pass, 0 fail).
  • The contributor's readiness checklist was left unticked; the maintainer validation above stands in for it. This is maintainer integration, not an approving review.

@lidge-jun
lidge-jun merged commit 0c32c81 into lidge-jun:dev Oct 27, 2026
30 of 31 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-27T18:51:28.367990Z
We couldn’t complete this review. Comment @codex review to try again.
c1584c0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbamlee
jbamlee deleted the jbamlee/native-fast-1m-pr branch October 28, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants