You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(gui): remote-link Add child focus-restore case is flaky on macOS #7611
gui/tests/remote-link.test.tsx case "discovery loading, empty setup and rescan retain keyboard-accessible manual entry" is flaky on macOS. After the Add child sheet is cancelled, focus is expected to return to the "Add child" button, but document.activeElement text is sometimes empty. This predates the 2.92.0 train (it fails more often on v2.91.0) and was found during 2.92.0 release-candidate verification at dev 03bcf78. Not release-blocking; CI was green on that head.
Reproduction
cd gui
foriin$(seq 1 20);do bun test --isolate tests/remote-link.test.tsx 2>&1| grep -q '^ *0 fail$'||echo fail;done| wc -l
Run with the pinned test runner (Bun 1.4.3). Measured failures: 13/20 at dev 03bcf78 and 18/20 at v2.91.0. Also failed once in a full bun run test from gui/ (3492 pass / 1 fail).
Expected: the cancel handler restores focus to the "Add child" trigger every run.
Actual: intermittently no focused element at the assertion at gui/tests/remote-link.test.tsx:931.
error: expect(received).toContain(expected)
Expected to contain: "Add child"
Received: ""
at gui/tests/remote-link.test.tsx:931:51
(fail) discovery loading, empty setup and rescan retain keyboard-accessible manual entry
The run prints "An update to FallbackPanel inside a test was not wrapped in act(...)" just before the failure, which suggests focus restore depends on async state settling after the assertion.
Screenshots and supporting files
No response
Redacted configuration
No response
Checks
I searched existing issues and documentation.
I removed secrets, tokens, account details, request credentials, and personal data.
Activity
fix(gui): cancel Remote Link sheet focus work (#7611) (#7650)
lidge-jun commentedon Oct 24, 2026
Fixed on dev by #7650 (merge commit a033a1a).