Repository navigation
Commit ff93784
committed
fix(gui): keep the inset rationale in one place
The stylesheet rule, the test file header, and three per-assertion comments
each restated the same two facts — that `.card` has no padding and that the
warning box needs margin rather than padding. CodeRabbit's slop detector
flagged the repetition, and it was right: the explanation belongs on the CSS
rule, where the values it justifies live.
The test header now points at that rule and keeps only what is specific to
the test — why the assertions read source text rather than measuring, and
the browser measurements the contract is derived from. The comments that
survive per assertion are the ones the CSS does not carry: why the rule
regex is anchored, how a shorthand is read, and why an inline style would
silently disable the fix.1 parent 5da7f7b commit ff93784
2 files changed
Lines changed: 6 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1764 | 1764 | | |
1765 | 1765 | | |
1766 | 1766 | | |
1767 | | - | |
| 1767 | + | |
| 1768 | + | |
1768 | 1769 | | |
1769 | 1770 | | |
1770 | 1771 | | |
| |||
1777 | 1778 | | |
1778 | 1779 | | |
1779 | 1780 | | |
1780 | | - | |
1781 | 1781 | | |
1782 | 1782 | | |
1783 | 1783 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 9 | + | |
| 10 | + | |
16 | 11 | | |
17 | 12 | | |
18 | 13 | | |
| |||
66 | 61 | | |
67 | 62 | | |
68 | 63 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 64 | | |
73 | 65 | | |
74 | 66 | | |
75 | 67 | | |
76 | 68 | | |
77 | 69 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 70 | | |
82 | 71 | | |
83 | 72 | | |
84 | 73 | | |
85 | 74 | | |
86 | 75 | | |
87 | | - | |
88 | | - | |
89 | 76 | | |
90 | 77 | | |
91 | 78 | | |
| |||
0 commit comments