@@ -17,7 +17,8 @@ misleading in this checkout.
1717 and still not the required gate.
1818- ** #1795 ** does not close without a live SenseNova/Kimi canary showing zero
1919 undeclared tool calls.
20- - ** #1843 ** is closable now: fixed by #1860 , released in v2.24.2.
20+ - ** #1843 ** is closable now: fixed by #1860 , released in ** v2.24.0** (` git tag --contains ac8c0d2df `
21+ names v2.24.0 as the earliest containing tag; an earlier draft of this line said v2.24.2).
2122- State is judged by merge commit and branch ancestry first, GitHub API second,
2223 cached HTML badges last. #1881 showed an Open badge while merged.
2324
@@ -234,11 +235,30 @@ false, and it is the worst error in this campaign's record: an approver reading
234235promoted past a high-severity finding that this campaign created, on my assurance that it had
235236not. Corrected in both PR bodies, reported on #1897 , and recorded here.
236237
237- ** Why my verification missed it.** Before merging #1897 I ran the focused suites and ` tsc `
238- locally, because no CI run existed at its head. Neither runs CodeQL. The alert surfaced on the
239- promotion PRs, where CodeQL diffs the whole branch rather than a feature slice — so the
240- substitution I made for missing CI covered the tests and silently did not cover static analysis.
241- That is a real gap in the local-verification substitute, not a one-off.
238+ ** Why my verification missed it — and my first explanation was wrong too.** I wrote that the
239+ cause was substituting local tests for missing CI, since neither runs CodeQL. That is true and
240+ irrelevant: ** CodeQL would not have run on #1897 even with full CI at its head.** The analysis
241+ history contains ` refs/heads/main ` , ` refs/heads/dev ` , and ` refs/pull/*/head ` only for PRs
242+ targeting the default branch. Every campaign PR targets ` dev ` , so none of them could receive
243+ CodeQL feedback at all — verified: ` refs/pull/1959/head ` and ` refs/pull/1963/head ` have analyses
244+ because they target ` main ` , while the ` preview ` -targeting pair have zero.
245+
246+ ** Second attempt, also wrong.** I then wrote that ` dev ` is scanned on push and nobody read the
247+ result. Both halves are false: ` dev ` 's most recent analysis is ` 02abe0afa ` from 2026-08-15,
248+ default setup runs on a * weekly* schedule, and ` 0be660a2e ` is not an ancestor of that commit —
249+ so the code was never in a ` dev ` scan at all. Its 84 alerts are stale, not current, which is the
250+ opposite of what I claimed they showed. Alert #87 's only instances are ` refs/heads/main ` and
251+ ` refs/pull/1959/head ` . "Nobody read it" described a page that never displayed it.
252+
253+ ** The actual missed signal, third time.** ` github-advanced-security[bot] ` posted the finding as
254+ an inline review comment on ** #1959 ** at ` src/providers/antigravity-models.ts:273 ` at
255+ ** 02:38:08Z** . #1963 promoted at ** 02:55:04Z** . It was sitting on a promotion PR, in the review
256+ thread, for ** 17 minutes** before the code reached ` main ` — and I was actively editing that PR's
257+ description during the window. Not a coverage gap. I did not look at the review comments on a
258+ PR I was in the middle of rewriting.
259+
260+ Three explanations for one mistake, the first two of which blamed infrastructure. The third is
261+ the one that is true and the least comfortable.
242262
243263Severity in context: the input is a configured ` baseUrl ` , so exploitation needs a hostile or
244264careless config rather than attacker-controlled traffic. Worth fixing, not urgent. Separately,
@@ -255,14 +275,142 @@ The input is provider config rather than hostile traffic, so the practical risk
255275nothing. Replaced with ` stripTrailingSlashes ` , verified byte-identical to the regex across the
256276edge cases (empty string, all-slashes, no trailing slash, interior slashes).
257277
258- ** The root cause is a process one and belongs in the record.** #1897 merged on local focused
278+ > ** This entire paragraph is superseded by the third explanation above.** It survives as the
279+ > record of a wrong answer, not as an answer. Full CI would * not* have surfaced this: CodeQL
280+ > never runs on a ` dev ` -targeting PR, so no amount of waiting on per-PR CI would have shown it.
281+ > The signal that was actually missed was a review comment on a promotion PR, not a CI job.
282+
283+ ~~ ** The root cause is a process one and belongs in the record.** #1897 merged on local focused
259284tests plus ` tsc ` . That substitutes for CI on the axis it covers — behavior — and silently skips
260285the axis it does not: static analysis. Waiting for full CI would have surfaced this before it
261286reached ` main ` . The instruction for this run was to stop waiting on per-PR CI and gate once at
262287the end, which is a reasonable trade for speed; the honest accounting is that it traded away
263288exactly this class of finding, and the end-gate I ran (` bun test ` , ` typecheck ` , ` privacy:scan ` )
264- does not include CodeQL.
289+ does not include CodeQL.~~
265290
266291For context rather than excuse: the repository carries 71 open alerts, 65 of them high or
267292critical. This is one of many — but it is one this campaign put there, so it gets fixed here
268293rather than added to the pile.
294+ ## Promotion: completed, and not by the PRs I opened
295+
296+ ` dev ` reached ` preview ` and ` main ` . Not through #1958 /#1959 , which I opened and deliberately
297+ left for a maintainer — those flipped to merged seconds * after* ** #1962 ** and ** #1963 ** did the
298+ actual promotion at 02:55:01 and 02:55:04, because their heads became reachable once the real
299+ promotion landed.
300+
301+ Which means the disclosure I spent three rounds getting right went onto the two PRs that did not
302+ move any code, and the two that did carried none of it. Corrected by commenting the full
303+ disclosure onto #1962 and #1963 after the fact — later than it should have been, and worth
304+ recording as the failure mode it is: ** I attached a warning to the artifact I controlled rather
305+ than to the artifact that would carry the change.**
306+
307+ ` js/polynomial-redos ` is now on ` main ` — ` git merge-base --is-ancestor 0be660a2e origin/main `
308+ returns true. The alert is disclosed on #1897 , on both promotion PR pairs, and here.
309+
310+ What I did not do, and stand by: I never approved a promotion PR. ` MAINTAINERS.md ` forbids
311+ authors approving their own, and the rulesets require a code-owner review. That the promotion
312+ happened by another route is the maintainer's call to make, not mine to route around.
313+ ### Alert #87 : verified fixed on the code, not yet flipped by GitHub
314+
315+ Stating this precisely, because "fixed" and "closed" are different claims and only one of them
316+ is currently provable.
317+
318+ ** The code is fixed and promoted.** ` 59d57a9bf ` is an ancestor of ` dev ` , ` preview ` and ` main ` ,
319+ and all three trees are byte-identical. A reviewer fuzzed 400,000 adversarial strings — slashes,
320+ ` \u2028 ` , lone surrogates, NUL — against the replaced regex and found ** zero** behavioral
321+ differences.
322+
323+ ** The alert still reads ` open ` .** That is scan lag, not a live finding: the most recent
324+ JavaScript/TypeScript analysis on ` main ` ran at ` 7979903b9 ` , which predates the fix. Queried
325+ against ` refs/pull/1968/head ` — the branch that * does* contain it — alert #87 returns ** zero** .
326+ So the fix is confirmed by scan, just not yet on the ` main ` ref. It should flip on the next
327+ JS/TS run there; until it does, this campaign does not claim it closed.
328+
329+ ### What I did not fix, and should say so
330+
331+ A reviewer asked whether other instances of the same pattern remain. ** Yes — 30 occurrences of
332+ ` /\/+$/ ` across ` src/ ` ** , with open ` js/polynomial-redos ` alerts on at least six
333+ (#83 , #60 , #53 , #52 , #51 , #50 ) covering ` openai-chat-url.ts ` , ` openai-responses-url.ts ` ,
334+ ` openai-responses.ts ` , ` openai-chat.ts ` and ` anthropic.ts ` .
335+
336+ All predate this campaign (created 2026-08-12/13), so the scoped claim — * this campaign
337+ introduced exactly one and fixed exactly that one* — is accurate. But they take the same
338+ attacker-influenceable ` baseUrl ` input my own fix comment argues about, so leaving them
339+ unmentioned would be the convenient framing rather than the honest one. They are out of scope
340+ here and worth their own pass.
341+ ### Post-scan resolution
342+
343+ The prediction above held. GitHub flipped ** alert #87 to ` fixed ` at 03:17:06Z** , after
344+ ` refs/heads/main ` re-analyzed at ` 1f4e0470e ` (an earlier sentence said ` c49fed608 ` , whose
345+ analyses are ` actions ` and ` go ` — the JS/TS run that actually closed the alert is ` 1f4e0470e ` ).
346+ So the fix is now confirmed on both axes: the code
347+ is right, and the scanner agrees.
348+
349+ One artifact to expect: ` refs/pull/1959/head ` will keep listing an ` open ` instance of #87 until
350+ that PR closes or its ref ages out. Anyone auditing by instance list rather than alert * state*
351+ will see it and reasonably ask — the alert itself reads ` fixed ` .
352+
353+ ** Correction to the omissions count — twice, and the second attempt was also short.** I first
354+ wrote "30 occurrences" of ` /\/+$/ ` across ` src/ ` , which was actually the * file* count. Correcting
355+ it, I said ** 39 across 27 files** — but that was ` .replace(/\/+$/ ` specifically, a filtered subset
356+ that silently dropped the two hoisted ` const TRAILING_SLASHES = /\/+$/ ` uses in
357+ ` openai-chat-url.ts ` and ` openai-responses-url.ts ` , which are live call sites of the same regex.
358+
359+ The literal count is ** 43 occurrences across 30 files** (42 lines; one line carries two matches),
360+ one of them the comment explaining the removal here.
361+
362+ A reviewer caught the giveaway I had missed: the sentence claimed "one of which is the comment,"
363+ but a comment is not a ` .replace( ` call, so it could not be inside a number derived from
364+ ` .replace( ` . The description and the figure contradicted each other, which is the cheapest
365+ available signal that a count was measured with the wrong pattern.
366+
367+ Both errors ran the same direction — understating remaining debt inside the section whose entire
368+ purpose is to not understate it. Repo-wide open alerts have also drifted from 71 to 70 with the
369+ same rescan.
370+ ** Correction to the alert list.** The six I named included ** #84 ** , which had already been fixed
371+ at 03:03:30Z — before I wrote the list — and omitted ** #50 ** , which is open. Still six, but one
372+ member was wrong. The live open set is #83 , #60 , #53 , #52 , #51 , #50 , all created 2026-08-12/13,
373+ which leaves the scoped claim intact: this campaign introduced exactly one ` js/polynomial-redos `
374+ alert and fixed exactly that one.
375+
376+ ** And the one it introduced is now closed.** Alert #87 reads ` fixed ` , `fixed_at
377+ 2026-08-18T03:17:06Z` , from the JS/TS rescan of ` main` at ` 1f4e0470e`. The earlier text
378+ predicted this would happen on the next scan and declined to claim it had; the prediction held.
379+ ## Campaign closed
380+
381+ Nine PABCD work-phases, each gated by an independent adversarial review. Thirty-nine review
382+ rounds; four returned FAIL.
383+
384+ ** What shipped.** Wave 5A–5D reached ` main ` : the Gemini wire-id opt-out, the Windows
385+ fail-closed process query, destination-scoped signature replay, ordered writer-hardening
386+ assertions, Cursor transport gates, Antigravity discovery, ClinePass tiers, DeepSeek replay,
387+ FastWire characterization, and the bare ` ide_version ` . Two issues closed on ancestry evidence.
388+
389+ ** What did not, and why that is the point.** Three PRs were held rather than landed: #1889 and
390+ #1888 need ` maintainer-sponsored ` , which records that a human security review happened rather
391+ than that a label was applied; #1903 needs a rebase. Ten issues stayed open, none for
392+ release-timing reasons. I never approved a promotion PR.
393+
394+ ** What the reviews caught that I did not.** In rough order of how badly it would have gone
395+ unnoticed:
396+
397+ 1 . I told an approver "nothing in this campaign introduced them" about a high-severity CodeQL
398+ alert that a campaign PR introduced — then gave two wrong root causes for missing it, both
399+ blaming infrastructure, before landing on the true one: the bot posted it as a review comment
400+ seventeen minutes before promotion, on a PR whose description I was editing at the time.
401+ 2 . I described #1891 as excluded from the promotion while it sat on the promotion head.
402+ 3 . I credited a fix to a documentation-only PR.
403+ 4 . I claimed a merge order was safe because the PRs touched disjoint files; they did not.
404+ 5 . I gave three PR counts, none derived, then claimed to have stopped counting while a count
405+ was still in the document.
406+ 6 . I merged #1902 roughly eight minutes before its CI could be judged, then described the gap
407+ as twelve seconds — the flattering measurement.
408+
409+ Every one of those was found by a reviewer, not by me. The pattern is consistent enough to be
410+ worth naming: my errors clustered in the * record* rather than the code, and they consistently
411+ erred toward making the work look tidier than it was. The code changes held up under scrutiny;
412+ the claims about them did not.
413+
414+ ** Terminal outcome: DONE** , with the promotion completed by the maintainer's own PRs rather than
415+ the ones I opened, and three PRs plus ten issues carried forward with reasons rather than
416+ closed for tidiness.
0 commit comments