Repository navigation
Commit f408914
committed
fix(cli): give noVisionModels precedence over an exact modality entry
isModelTextOnly returns true on the noVisionModels match before it ever
reads modelInputModalities, so a `gpt-oss` noVision entry beats an exact
`gpt-oss:120b` entry that lists "image". Resolving the exact entry first
made `ocx models` advertise image support the proxy then rejects — the
same class of drift this PR set out to remove.
Add the conflicting-config regression case, which asserts the runtime's
answer via isModelTextOnly before comparing the CLI's.
Thanks @coderabbitai for catching it.1 parent 71ed29d commit f408914
2 files changed
Lines changed: 37 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
105 | 108 | | |
106 | | - | |
| 109 | + | |
107 | 110 | | |
108 | 111 | | |
109 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
206 | 239 | | |
207 | 240 | | |
208 | 241 | | |
| |||
0 commit comments