Repository navigation
Commit eef9a86
committed
fix(responses): tell TLS hostname mismatches apart from an unreachable provider
A certificate that does not cover the host it was served for surfaced as
`Provider unreachable: ERR_TLS_CERT_ALTNAME_INVALID fetching https://...`,
which reads as if opencodex had built a wrong endpoint. Issue #553 was
filed on that reading — the reporter concluded the adapter was mangling
the Copilot URL, and a maintainer could not reproduce it because the URL
was correct all along. That error almost always means TLS interception
(corporate proxy, VPN, local MITM tooling) or a poisoned DNS answer, none
of which the proxy can fix or is at fault for.
The message now names the host, says the proxy did not rewrite it, and
gives the openssl s_client command that settles which certificate is
actually being served.
The same three-line shape was duplicated at three catch sites in core.ts,
so it moves into one helper. Sites 2 and 3 delegate entirely; site 1
keeps its own `outcome` ternary because that value also feeds
recordCodexUpstreamOutcome. Verified byte-identical output against the
old expression for TimeoutError, plain Error, empty-message Error,
string, undefined, null, object and AbortError.
While rewriting the message, redact URL userinfo. A provider base URL can
carry credentials as `https://user:token@host/` and the runtime error
echoes the URL it was fetching, so the old text handed that straight back
to the caller. Both branches now strip it.
The code match is anchored to the head of the message rather than a bare
substring, so text that merely quotes the code back keeps the generic
wording.1 parent 0a356d7 commit eef9a86
3 files changed
Lines changed: 145 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
1194 | 1195 | | |
1195 | 1196 | | |
1196 | 1197 | | |
1197 | | - | |
| 1198 | + | |
1198 | 1199 | | |
1199 | 1200 | | |
1200 | 1201 | | |
| |||
1741 | 1742 | | |
1742 | 1743 | | |
1743 | 1744 | | |
1744 | | - | |
1745 | | - | |
1746 | | - | |
| 1745 | + | |
1747 | 1746 | | |
1748 | 1747 | | |
1749 | 1748 | | |
| |||
1783 | 1782 | | |
1784 | 1783 | | |
1785 | 1784 | | |
1786 | | - | |
1787 | | - | |
1788 | | - | |
| 1785 | + | |
1789 | 1786 | | |
1790 | 1787 | | |
1791 | 1788 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
0 commit comments