Repository navigation
Commit eebd191
committed
fix(google-antigravity): match the model component, not the whole Vertex identity
Ingwannu's review found the predicate scanned the entire raw replay identity.
The Vertex key is vertex:<project>:<location>:<modelId> and the project id is
operator-chosen, so a project named 'gemini-prod' armed the Gemini-only sentinel
for a non-Gemini model:
vertex:gemini-prod:global:gpt-oss-120b -> true (sentinel injected)
vertex:gemini-team:us:claude-fable-5 -> true
That is the same class of defect the predicate exists to prevent, reintroduced
one layer up — and my own tests missed it because they used a neutral project
name on the positive control.
Now reduces to the model component first: last ':' segment for a Vertex
identity, then last '/' segment for a namespaced id, anchored with ^. Positive
controls unchanged (vertex:proj:global:gemini-3-pro, google/gemini-3-pro,
gemini-3-pro, gemini-pro-agent all still true).
Mutation-verified: restoring the whole-string scan fails exactly the new test
(70/1); with the fix 71/0, and 160/0 across all four affected suites.1 parent 3468cea commit eebd191
2 files changed
Lines changed: 37 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
640 | 640 | | |
641 | 641 | | |
642 | 642 | | |
643 | | - | |
644 | | - | |
645 | | - | |
646 | | - | |
647 | | - | |
648 | | - | |
649 | | - | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
650 | 654 | | |
651 | 655 | | |
652 | | - | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
653 | 659 | | |
654 | 660 | | |
655 | 661 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1100 | 1100 | | |
1101 | 1101 | | |
1102 | 1102 | | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
1103 | 1126 | | |
1104 | 1127 | | |
1105 | 1128 | | |
| |||
0 commit comments