Skip to content

Commit ed719b5

Browse files
authored
devlog: wp1-wp5 disposition records for PRs #2439 #2437 #2435 #2433 #2387 (#2446)
1 parent aa37c8b commit ed719b5

6 files changed

Lines changed: 250 additions & 0 deletions
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
# 010 — wp1: PR #2439, fixture-backed OpenAI contract manifest
2+
3+
## Item
4+
5+
`Ingwannu` PR #2439 `ingw/refactor-provider-contracts` -> `dev`, head `0225f2b9`.
6+
Adds a strict V1 compatibility-manifest schema and catalog with one canonical
7+
OpenAI Codex-forward contract for `gpt-5.6-sol`, backed by production-adapter
8+
fixtures, plus synchronized documentation. 13 files.
9+
10+
## Reviewer verdict
11+
12+
`gpt-5.6-sol` high, read-only, exact head `0225f2b9`:
13+
14+
- VERDICT PASS_WITH_NITS, disposition SQUASH_MERGE, risk low.
15+
- `bun test tests/compatibility-manifest.test.ts` 6 pass / 0 fail.
16+
- `bun test tests/core-lab-boundary.test.ts` 13 pass / 0 fail.
17+
- `cd docs-site && bun run build` passed, 393 pages.
18+
- `gh pr checks 2439` 23 passed, 1 intentionally skipped, 0 failed.
19+
- Export and call-site tracing found no dropped exports, no import cycle, no
20+
core-to-manifest or core-to-Lab edge, no credential or request-body logging.
21+
22+
## The one nit, and why it does not block
23+
24+
`tests/compatibility-manifest.test.ts:67` — the graph guard skips every dynamic
25+
import, so a future direct `import("../compatibility")` from a protected core
26+
file would slip past it. The current tree has no such edge, and
27+
`tests/core-lab-boundary.test.ts` already carries the stricter direct-dynamic
28+
check for the Lab boundary. This is a guard-strength gap in a new test, not a
29+
defect in shipped behavior, so it is recorded rather than held.
30+
31+
## Disposition
32+
33+
Squash-merge. The manifest is additive and sits off the core request path.
34+
35+
## Verification
36+
37+
Post-merge on `dev`: `bun test tests/compatibility-manifest.test.ts
38+
tests/core-lab-boundary.test.ts`, bound to the merged tree by a check receipt.
39+
40+
41+
## Execution record
42+
43+
Squash-merged 2026-08-23 as `2a2f6e68f` on `origin/dev`, branch deleted.
44+
45+
```
46+
gh pr merge 2439 --squash --admin --delete-branch
47+
2a2f6e68f feat(compatibility): add fixture-backed OpenAI contract manifest (#2439)
48+
```
49+
50+
No linked issue: #2439 stands on its own.
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# 020 — wp2: PR #2437 and issue #2436, history manifest contract
2+
3+
## Item
4+
5+
`Ingwannu` PR #2437 `ingw/refactor-history-manifest-boundary-2436` -> `dev`,
6+
head `f1774833`. Closes issue #2436, "extract the Codex history manifest
7+
contract into a shared leaf".
8+
9+
Extracts manifest types, provenance validation, path identity, and backup IDs
10+
into a pure builtin-only leaf module.
11+
12+
## Reviewer verdict
13+
14+
`gpt-5.6-sol` high, read-only:
15+
16+
- VERDICT PASS, disposition MERGE, risk low, no nits.
17+
- `bun test tests/codex-history-provider.test.ts tests/codex-native-residue.test.ts tests/core-lab-boundary.test.ts` -> 142 pass / 0 fail.
18+
- `gh pr checks 2437` -> 23 passed, 1 expected matrix job skipped, 0 failed.
19+
- Both callers keep their filesystem, SQLite, mutation, and diagnostic
20+
responsibilities. No dropped export, no import cycle, core/Lab boundary intact,
21+
no request-body or credential logging change.
22+
23+
## Disposition
24+
25+
Merge, then close #2436 by hand. PRs here target `dev`, so GitHub does not
26+
auto-close the linked issue.
27+
28+
29+
## Execution record
30+
31+
Squash-merged 2026-08-23 as `81474259e` on `origin/dev`, branch deleted.
32+
Issue #2436 closed by hand with the merge SHA and the reviewer's test evidence.
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# 030 — wp3: PR #2435 and issue #2434, Responses fetch-helper boundary
2+
3+
## Item
4+
5+
`Ingwannu` PR #2435 `ingw/refactor-fetch-helper-boundary-2434` -> `dev`, head
6+
`be6ea98a`. Closes issue #2434, "keep Responses fetch helpers on a
7+
transport-only import boundary".
8+
9+
Removes stale runtime imports from `src/server/responses/fetch-helpers.ts` and
10+
pins the permitted runtime edges with a regression test.
11+
12+
## Reviewer verdict
13+
14+
`gpt-5.6-sol` high, read-only, exact head `be6ea98a`:
15+
16+
- VERDICT PASS, disposition SQUASH_MERGE, risk low, no nits.
17+
- Six focused files (`responses-fetch-helpers-boundary`, `fetch-header-timeout`,
18+
`request-pacing`, `upstream-http-version`, `ws-upstream`,
19+
`core-lab-boundary`) -> 71 passed, 1 skipped, 0 failed.
20+
- CI 23 checks passed, 1 conditional Windows shard skipped, at the exact head.
21+
- Complete export surface preserved, helper implementations byte-identical, the
22+
new guard at `tests/responses-fetch-helpers-boundary.test.ts:43` rejects
23+
computed dynamic-import bypasses. No cycle, no logging, credential, routing, or
24+
behavior change.
25+
26+
## Disposition
27+
28+
Squash-merge, then close #2434 by hand.
29+
30+
31+
## Execution record
32+
33+
Squash-merged 2026-08-23 as `4fb0fbe7b` on `origin/dev`, branch deleted.
34+
Issue #2434 closed by hand with the merge SHA and the reviewer's evidence.
Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
# 040 — wp4: PR #2433, combo zero-output failover
2+
3+
## Item
4+
5+
`Ingwannu` PR #2433 `ingw/fix-combo-zero-output-failover-2431` -> `dev`, head
6+
`3ec2b1a6`. Addresses issue #2431, "failover combos stop on zero-output SSE
7+
terminal failures and model-EOL HTTP 410 responses".
8+
9+
Adds a bounded SSE preflight so failover combos can retry terminal failures
10+
before any output is committed, plus model-lifecycle HTTP 410 classification and
11+
synchronized documentation. 12 files.
12+
13+
## Reviewer verdict: FAIL
14+
15+
`gpt-5.6-sol` high, read-only, exact head `3ec2b1a6`:
16+
17+
- VERDICT FAIL, disposition NEEDS_CHANGES, risk medium.
18+
- `bun test tests/combos.test.ts tests/combo-stream-preflight.test.ts tests/server-combo-failover-e2e.test.ts tests/core-lab-boundary.test.ts` -> 126 passed, 0 failed, 694 assertions.
19+
- `gh pr checks 2433` -> 23 passed, 1 skipped, 0 failed.
20+
21+
Green tests and green CI, and still not landable. That gap is the point of the
22+
finding: the defect is in accounting the existing tests do not assert.
23+
24+
## The blocker
25+
26+
`src/server/responses/core.ts:1974` — the new preflight manually records a failed
27+
terminal. Native forward and pool passthrough streams already record that same
28+
physical terminal through their eager and tee inspectors at `:3785` and `:3868`.
29+
The once-guard added at `:1930` wraps only the exported callback, so it never
30+
observes the inspector's direct invocation.
31+
32+
One physical 502 therefore increments native account health twice. A production
33+
recorder diagnostic confirmed `consecutiveFailures: 2` for a single terminal.
34+
The practical effect is that soft-avoid and credential rotation fire at half the
35+
configured threshold, on an account that is healthy.
36+
37+
Everything else checked clean: stream commit boundary, attempt receipts, usage
38+
handling, marker preservation, export surface, ESM/Bun constraints, no core-to-Lab
39+
edge, no import cycle, no sensitive logging, translated docs aligned, template
40+
complete.
41+
42+
## Disposition
43+
44+
Hold. Not closed, not merged. The required change is a single shared
45+
once-guarded recorder owning both the preflight path and the inspector path, with
46+
a regression asserting exactly one health transition per streamed attempt.
47+
48+
That fix is being built on `codex/fix-2433-exactly-once-terminal` rather than
49+
asked of the contributor, because the PR is otherwise complete and the defect is
50+
in a seam the original author had no reason to suspect. wp4 closes on the review
51+
being posted; the landing of the corrected work is its own later work-phase.
52+
53+
54+
## Execution record
55+
56+
Review posted on #2433 on 2026-08-23 naming the blocker, the reproduction, and the
57+
required shape of the fix. PR left open, not closed. Fix in flight on
58+
`codex/fix-2433-exactly-once-terminal`.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# 050 — wp5: PR #2387 and issue #2378, proxy process-state ownership
2+
3+
## Item
4+
5+
`Ingwannu` PR #2387 `ingw/refactor-process-state` -> `dev`. Closes issue #2378,
6+
"extract proxy process-state ownership from config persistence".
7+
8+
Extracts OpenCodex-home paths, atomic writes, and PID/runtime-port ownership into
9+
three acyclic config leaf modules, keeping `src/config.ts` compatibility exports.
10+
11+
## Reviewer verdict
12+
13+
`gpt-5.6-sol` high, read-only:
14+
15+
- VERDICT PASS_WITH_NITS, disposition SQUASH_MERGE, risk medium.
16+
- Eight suites (`process-state`, `config`, `process-control`, `proxy-liveness`,
17+
`port-reclaim`, `service`, `update-job`, `core-lab-boundary`) -> 472 pass / 0 fail.
18+
- `stale-state-purge` -> 4 pass / 0 fail.
19+
- Synthesized current-`dev` merge -> 473 pass / 0 fail, `bun run typecheck` passed.
20+
- `gh pr checks 2387` -> 29 pass, 1 skipped, 0 failures.
21+
- Lifecycle, management, service, OAuth, and update callers import process state
22+
directly without changing their destructive identity checks. No request-body or
23+
API-key logging, no dropped runtime export, no import cycle, no core-to-Lab edge.
24+
25+
## Nits, recorded not held
26+
27+
- `tests/process-state.test.ts:6` — the dedicated suite does not exercise
28+
`readAlivePid()`, `verifyPidIdentity()`, or the `EPERM` behavior #2378 asks for.
29+
- `tests/config.test.ts:2216` — process-state characterization is duplicated;
30+
owner behavior should move fully to `process-state.test.ts`.
31+
32+
Both are test-ownership improvements on a behavior-preserving extraction whose
33+
coverage already runs 472 green. Recorded as follow-up rather than blocking a
34+
maintainer refactor that is otherwise clean.
35+
36+
## Disposition
37+
38+
Squash-merge, then close #2378 by hand.
39+
40+
41+
## Execution record
42+
43+
Squash-merged 2026-08-23 as `b6c7c0afe` on `origin/dev`, branch deleted.
44+
Issue #2378 closed by hand with the merge SHA, the reviewer's evidence, and the
45+
two test-ownership follow-ups stated openly rather than quietly dropped.
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# 060 — wp6: PR #2380 and issue #2379, provider validation boundary
2+
3+
## Item
4+
5+
`Ingwannu` PR #2380 `ingw/refactor-provider-validation` -> `dev`. Closes issue
6+
#2379, "extract provider validation from config persistence".
7+
8+
Moves 11 pure provider-validation helpers and three supporting constants into a
9+
focused leaf module.
10+
11+
## Reviewer verdict
12+
13+
`gpt-5.6-sol` high, read-only:
14+
15+
- VERDICT PASS, disposition MERGE, risk low, no actionable findings.
16+
- `bun test tests/provider-config-validation.test.ts tests/management-provider-validation.test.ts tests/management-origin-tls.test.ts tests/server-auth.test.ts tests/core-lab-boundary.test.ts` -> 187 pass / 0 fail.
17+
- `bun test tests/config.test.ts` -> 153 pass / 0 fail. `bun run typecheck` -> pass.
18+
- `gh pr checks 2380` -> 23 pass, 1 skipped, 0 failures.
19+
- All function bodies match the originals. `src/config.ts` retains every
20+
compatibility re-export while direct consumers take the narrower dependency.
21+
Auth/CORS behavior, logging, persistence, response shapes, and the core/Lab
22+
boundary are unchanged. The current dev merge tree is clean.
23+
24+
This PR touches provider validation, which sits next to the auth surface, so the
25+
reviewer was asked to trace it as a security-adjacent change. It found no
26+
behavior delta in auth or CORS handling.
27+
28+
## Disposition
29+
30+
Merge, then close #2379 by hand.
31+

0 commit comments

Comments
 (0)