You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ed0d5af
Browse filesBrowse the repository at this point in the historyBrowse files
docs(devlog): record the WP3 outcome, including two self-inflicted defects
Both were found by auditing rather than by tests, which is the part worth
keeping: the extraction dropped ProcessSnapshot.owner and everything stayed
green, and the collector's fail-closed catch covered only the default
enumerator, so the regression test for this work-phase would have been
asserting the safety of a path the injected seam does not share.
Also records the gap this cannot close on macOS. The tests drive an injected
PowerShell runner, so no PowerShell ever parses the emitted script - and a
syntax error there is not catchable by try/catch in the same scriptblock,
which would reintroduce the exact fail-open the change exists to fix.
Copy file name to clipboardExpand all lines: devlog/_plan/260817_wave5_execution/030_1876_windows_discovery.md
+35Lines changed: 35 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -75,3 +75,38 @@ than implying platform coverage.
75
75
76
76
#1876 merges after the top-level fix; #1852 closes citing the merge SHA plus the
77
77
top-level-failure regression test.
78
+
## Outcome (executed)
79
+
80
+
DONE with one open evidence gap. Three commits:
81
+
82
+
| Commit | Change |
83
+
|--------|--------|
84
+
|`dc1df7d44`|`-ErrorAction Stop` + outer catch on the top-level query; parse loop extracted to `parseWindowsSnapshotOutput`; `listWindowsSnapshots` takes an optional runner; the collector's fail-closed catch now covers the injected seam too |
85
+
|`497b64338`| full-row fixture pinning every parsed field |
86
+
|`535e3c256`|`unknown` cached for 250ms instead of the uniform 5s (accept criterion 3) |
87
+
88
+
**Two defects found in my own work, both by auditing rather than by tests.**
89
+
90
+
The extraction silently dropped `ProcessSnapshot.owner` and every test still
91
+
passed — the two states these tests assert never read it, and the ownership
92
+
decisions that do live in other modules with their own doubles. It was caught by
93
+
diffing against `4d9738f43`, and the full-row fixture exists so the next refactor
94
+
cannot repeat it.
95
+
96
+
`collectCodexAppServerCatalogState` wrapped only the *default* enumerator in its
97
+
try, so an injected `listSnapshots` that threw would propagate instead of
98
+
degrading to `unknown`. No caller was broken in practice, but the regression test
99
+
for this work-phase would have been asserting the safety of a path the seam does
100
+
not share. Both paths now go through one catch — the shape
101
+
`src/codex/log-guard/processes.ts` already had.
102
+
103
+
**Open gap, recorded rather than implied.** There is no real-Windows evidence.
104
+
`platform-windows` is `workflow_dispatch`-only and the aggregate accepts it as
105
+
skipped. The reviewer's sharpest point stands: the tests drive an injected
106
+
`runPowerShell`, so no PowerShell ever parses the emitted script, and a *syntax*
107
+
error is not catchable by `try/catch` in the same scriptblock — it fails at parse
108
+
time, writes to stderr (which is `stdio: "ignore"`), and leaves stdout empty,
109
+
reintroducing precisely the fail-open this fixes. A second, milder risk:
110
+
`-ErrorAction Stop` promotes non-terminating CIM errors to terminating, so a benign
111
+
per-instance error could turn a mostly-complete read into a persistent `unknown`.
112
+
Both need a maintainer-triggered dispatch on the merged head.
0 commit comments