You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e8b36b0
Browse filesBrowse the repository at this point in the historyBrowse files
fix(web-search): tell the operator when a bridge endpoint is refused
A provider keyed under a custom name, say "my-ollama", pointing at
http://127.0.0.1:11434/api/web_search armed before the destination check and
disarms after it, because only the registry ids (ollama, vllm, lm-studio,
litellm) are local by default. Two properties combined to make that invisible:
config load never runs providerWebSearchBridgeConfigError, so the block loads
cleanly, and the plan-time refusal returns undefined by design so the key stays
unspent. The operator's web search stopped working with no signal at all.
resolveOllamaWebSearchEndpoint now warns once per provider and endpoint when the
refusal is a destination decision, naming the two remedies: set
allowPrivateNetwork, or key the provider under its registry id. The planner runs
per request, so the warning is deduplicated and the dedupe set is bounded. The
destination URL is never logged and the provider key goes through
redactSecretString, since a provider key is caller-controlled.
Adds the coverage the review named as missing: a metadata endpoint survives
validateConfigCandidate intact and is then refused at plan time, which pins the
load-path behavior the whole argument rests on rather than simulating it.
0 commit comments