Repository navigation
Commit e4a85d1
committed
fix(release): stop dev from carrying a version behind its own releases
dev accumulated 254 commits without touching package.json, so its version
string (2.32.1-preview.20260825) ended up BEHIND the published latest dist-tag
(2.33.0) once v2.33.0 was cut from main. One stale line, two failure modes:
- assertChannelVersionMovesForward refuses the string as a channel
regression, so a release cut from this tree cannot publish at all.
- merging dev into main resolves package.json to main's side, yielding a tree
that claims to be the already-published 2.33.0 - a silent duplicate rather
than a loud failure.
2.34.0 is the target: npm returns E404 for it, no v2.34.0 tag exists, and it
moves latest forward. Minor rather than patch follows the precedent in
32529c2 - the range carries new providers, new config surfaces, GUI work and
adapter contract changes, not only fixes.
The regression test is the part that lasts. 32529c2 repaired this same
condition by hand and nothing has enforced it since. tests/release-version-line
asserts the in-tree version is strictly ahead of the highest local release tag,
and was driven red against the exact string dev carried before this commit. It
reads local tags rather than the npm registry so it needs no network and no edit
per release, and reports nothing when no tags are present, because
actions/checkout fetches none by default and an empty set cannot prove a
regression.
It imports compareReleaseTags from scripts/release-notes rather than
scripts/release: the latter parses process.argv and calls process.exit at module
scope, so importing it from a test kills the runner.
This does not publish, tag, or promote. scripts/release.ts still refuses to run
anywhere but main/preview.1 parent 9919438 commit e4a85d1
2 files changed
Lines changed: 98 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
0 commit comments