Repository navigation
Commit e1e4313
committed
fix(oauth): preserve typed reauth identity errors in public projection
The public OAuth error projection from #1842 collapsed the fixed
reauth-identity remediation messages (identity mismatch, unverifiable
legacy identity) into the generic authentication failure, so the
dashboard could no longer tell the user to sign in with the selected
account. Represent both outcomes as bounded typed errors
(OAuthReauthIdentityMismatchError, OAuthReauthIdentityUnverifiedError)
whose messages carry no account, token, or email data, allowlist them
in publicOAuthAuthenticationErrorMessage, and cover them in the
projector allowlist and management status-polling regressions.
Resolves the unresolved P2 review on #1842.
Credit: original redaction work by @luvs01 in #1842.1 parent d5dbb28 commit e1e4313
2 files changed
Lines changed: 36 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
311 | 325 | | |
312 | 326 | | |
313 | 327 | | |
| |||
318 | 332 | | |
319 | 333 | | |
320 | 334 | | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
321 | 339 | | |
322 | 340 | | |
323 | 341 | | |
| |||
1137 | 1155 | | |
1138 | 1156 | | |
1139 | 1157 | | |
1140 | | - | |
| 1158 | + | |
1141 | 1159 | | |
1142 | 1160 | | |
1143 | 1161 | | |
1144 | 1162 | | |
1145 | 1163 | | |
1146 | 1164 | | |
1147 | 1165 | | |
1148 | | - | |
| 1166 | + | |
1149 | 1167 | | |
1150 | 1168 | | |
1151 | 1169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
256 | 258 | | |
257 | 259 | | |
258 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
259 | 267 | | |
260 | 268 | | |
261 | 269 | | |
| |||
370 | 378 | | |
371 | 379 | | |
372 | 380 | | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
373 | 389 | | |
374 | 390 | | |
375 | 391 | | |
| |||
0 commit comments