Repository navigation
Commit e1769b5
fix(server): default store:false on /v1/responses inbound when omitted (#1743)
* fix(server): default store:false on /v1/responses inbound when omitted
Generic Responses-API clients (AI-SDK apps such as ZCode) omit store, but
the Codex backend rejects a native request without an explicit store:false
("Store must be set to false"). The chat-completions inbound already
defaults store:false when absent (src/server/chat-completions.ts); apply
the same default to the /v1/responses inbound so generic Responses
clients work against native openai routes. Explicit values are never
overridden. Adjacent context: #882 covered the outbound forward path.
* fix(server): scope store:false default to the canonical forward Codex backend
The unconditional /v1/responses inbound default also hit stateful key-auth Responses upstreams (official OpenAI API, gateways), where an omitted store intentionally enables server-side storage for later previous_response_id continuation. Apply the default only after routing settles and only for authMode "forward" + openai-responses providers, mirroring the provider-level forward predicate in usesCodexForwardPoolAuth. Explicit store values are never overridden. Adds a key-auth negative regression test alongside the forward positive cases.
* test(responses): pin forward-route explicit store:false preservation
Completes the auth-mode x explicit-value matrix in the store-default
regression suite: forward-auth routes must keep an explicit store:false
untouched, not just an explicit store:true.
* fix(server): gate store:false default on the canonical Codex forward base URL
Per review: reuse isCanonicalOpenAiForwardProvider() so custom Responses-
compatible forward gateways keep the omitted-store server-side default
instead of receiving an injected store:false. Adds the requested negative
regression (non-canonical forward gateway + omitted store stays omitted)
and points the forward fixtures at the canonical Codex base URL.
---------
Co-authored-by: SOSANA <[email protected]>1 parent 7d4ac11 commit e1769b5
2 files changed
Lines changed: 135 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1080 | 1080 | | |
1081 | 1081 | | |
1082 | 1082 | | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
1083 | 1096 | | |
1084 | 1097 | | |
1085 | 1098 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
0 commit comments