Skip to content

Commit e16c92e

Browse files
committed
feat(gui): show reset credit expiration time
1 parent 0d17425 commit e16c92e

4 files changed

Lines changed: 43 additions & 3 deletions

File tree

‎gui/src/components/codex-account-pool-helpers.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { TFn } from "../i18n/shared";
22
import { IconTicket } from "../icons";
33
import type { CodexAccountEntry } from "./codex-account-pool-types";
4-
import { daysUntil, formatCreditDate } from "./codex-account-pool-utils";
4+
import { daysUntil, formatCreditDate, formatCreditDateTime } from "./codex-account-pool-utils";
55

66
export function CodexCreditItem({ index, grantedAt, expiresAt, isNext, t }: {
77
index: number; grantedAt: string; expiresAt: string; isNext: boolean; t: TFn;
@@ -19,7 +19,7 @@ export function CodexCreditItem({ index, grantedAt, expiresAt, isNext, t }: {
1919
</div>
2020
<div className="credit-item-dates">
2121
<span>{t("codexAuth.creditGranted", { date: formatCreditDate(grantedAt) })}</span>
22-
<span className={urgent ? "credit-urgent" : ""}>{t("codexAuth.creditExpires", { date: formatCreditDate(expiresAt), days: String(days) })}</span>
22+
<span className={urgent ? "credit-urgent" : ""}>{t("codexAuth.creditExpires", { date: formatCreditDateTime(expiresAt), days: String(days) })}</span>
2323
</div>
2424
</div>
2525
);
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,16 @@
1-
import { formatCreditDate as formatCreditDateIntl } from "../intl-formatters";
1+
import {
2+
formatCreditDate as formatCreditDateIntl,
3+
formatCreditDateTime as formatCreditDateTimeIntl,
4+
} from "../intl-formatters";
25

36
export function formatCreditDate(iso: string): string {
47
return formatCreditDateIntl(iso);
58
}
69

10+
export function formatCreditDateTime(iso: string): string {
11+
return formatCreditDateTimeIntl(iso);
12+
}
13+
714
export function daysUntil(iso: string): number {
815
return Math.max(0, Math.ceil((new Date(iso).getTime() - Date.now()) / 86_400_000));
916
}

‎gui/src/intl-formatters.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,26 @@ const CREDIT_DATE_FORMAT = new Intl.DateTimeFormat(undefined, {
2525
year: "numeric",
2626
});
2727

28+
const CREDIT_DATE_TIME_FORMAT = new Intl.DateTimeFormat(undefined, {
29+
month: "short",
30+
day: "numeric",
31+
year: "numeric",
32+
hour: "2-digit",
33+
minute: "2-digit",
34+
});
35+
2836
export function formatCreditDate(iso: string): string {
2937
const date = new Date(iso);
3038
if (Number.isNaN(date.getTime())) return "\u2014";
3139
return CREDIT_DATE_FORMAT.format(date);
3240
}
3341

42+
export function formatCreditDateTime(iso: string): string {
43+
const date = new Date(iso);
44+
if (Number.isNaN(date.getTime())) return "\u2014";
45+
return CREDIT_DATE_TIME_FORMAT.format(date);
46+
}
47+
3448
/** Format a USD cost estimate for display. Returns "—" when unavailable. */
3549
export function formatEstimatedUsdValue(value: number, locale?: string): string {
3650
if (!Number.isFinite(value) || value < 0) return "\u2014";

‎gui/tests/intl-formatters.test.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { describe, expect, test } from "bun:test";
2+
import { formatCreditDate, formatCreditDateTime } from "../src/intl-formatters";
3+
4+
describe("credit date formatting", () => {
5+
test("keeps the compact date format for grant dates", () => {
6+
expect(formatCreditDate("2026-07-31T12:34:56Z")).not.toContain("12:34");
7+
});
8+
9+
test("includes the local time for expiration dates", () => {
10+
const iso = "2026-07-31T12:34:56Z";
11+
12+
expect(formatCreditDateTime(iso)).not.toBe(formatCreditDate(iso));
13+
expect(formatCreditDateTime(iso)).not.toBe("—");
14+
});
15+
16+
test("handles invalid dates consistently", () => {
17+
expect(formatCreditDateTime("invalid")).toBe("—");
18+
});
19+
});

0 commit comments

Comments
 (0)