Repository navigation
Commit d539bd6
committed
fix(xai): declare grok image input so combos are not advertised text-only
xAI's registry entry had no modelInputModalities, so catalog rows for
xai/grok-4.5 carried inputModalities: undefined.
deriveComboCatalogModel intersects member modalities and defaults an
undefined member to ["text"], so every combo containing an xAI target was
published to Codex with input_modalities ["text"]. The Codex app gates
attachments client-side on that field, so images were rejected before a
request was ever routed, even though both combo members accept images.
This was visible with the documented xai -> cursor grok-4.5 failover combo:
cursor/grok-4.5 advertised ["text","image"] (via the noVisionModels sidecar
augmentation in applyProviderConfigHints) while xai/grok-4.5 advertised
nothing, and the resulting combo collapsed to text-only.
Declare the vision lineup for the grok-4.x chat models per
docs.x.ai model capabilities. grok-build-0.1 and grok-composer-2.5-fast are
intentionally omitted; they remain in noVisionModels.
Intersection semantics are unchanged: a member whose modalities are unknown
still narrows a combo to text, which the added regression test pins.1 parent 0ebb8fc commit d539bd6
2 files changed
Lines changed: 71 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
393 | 405 | | |
394 | 406 | | |
395 | 407 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
142 | 145 | | |
143 | 146 | | |
144 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
0 commit comments