Skip to content

Commit d313d2b

Browse files
committed
fix(routing): reject the reserved unknown service tier in profile requirements (RI-04)
1 parent dd10c9a commit d313d2b

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

‎src/routing/profile.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,11 @@ export function routingProfileIssues(
263263
}
264264
if (require.serviceTier !== undefined && typeof require.serviceTier !== "string") {
265265
issues.push({ path: ["require", "serviceTier"], message: "serviceTier must be a string" });
266+
} else if (require.serviceTier === "unknown") {
267+
issues.push({
268+
path: ["require", "serviceTier"],
269+
message: "serviceTier must not use the reserved \"unknown\" value (it encodes missing evidence)",
270+
});
266271
}
267272
}
268273
}

‎src/routing/trace.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export interface RouteCapabilityEvidence {
4646
image?: Unknownable;
4747
structuredOutput?: Unknownable;
4848
reasoningEfforts?: string[];
49+
/** `"unknown"` is reserved: it encodes missing evidence, never a real tier. */
4950
serviceTier?: string | "unknown";
5051
localOnly?: Unknownable;
5152
remoteAllowed?: Unknownable;

‎tests/routing-profile.test.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,15 @@ describe("routing profiles (RI-04)", () => {
185185
expect(duplicates.some(issue => issue.message.includes("duplicate"))).toBe(true);
186186
});
187187

188+
test("require rejects the reserved unknown service tier", () => {
189+
const config = baseConfig();
190+
const reservedTier = routingProfileIssues("p", {
191+
candidates: [{ provider: "a", model: "m1" }],
192+
require: { serviceTier: "unknown" },
193+
}, config);
194+
expect(reservedTier.some(issue => issue.path.join(".") === "require.serviceTier")).toBe(true);
195+
});
196+
188197
test("config load accepts valid profiles and rejects broken ones", () => {
189198
const valid = validateConfigCandidate(baseConfig());
190199
expect(valid.ok).toBe(true);

0 commit comments

Comments
 (0)