|
| 1 | +"use strict"; |
| 2 | + |
| 3 | +const { describe, it } = require("node:test"); |
| 4 | +const assert = require("node:assert/strict"); |
| 5 | +const { |
| 6 | + coderabbitOutsideDiffFindingIds, |
| 7 | + unresolvedFindingsClaim, |
| 8 | +} = require("./pr-quality-state.cjs"); |
| 9 | + |
| 10 | +const HEAD = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; |
| 11 | +const OUTSIDE_A = "cr-comment:v1:1d258eb2f6791036acf724b1"; |
| 12 | +const OUTSIDE_B = "cr-comment:v1:7a8b9c001122334455667788"; |
| 13 | + |
| 14 | +function review(overrides = {}) { |
| 15 | + return { |
| 16 | + id: 9001, |
| 17 | + commit_id: HEAD, |
| 18 | + submitted_at: "2026-08-07T06:00:00Z", |
| 19 | + user: { login: "coderabbitai[bot]" }, |
| 20 | + body: `**Actionable comments posted: 4**\n\n> [!CAUTION]\n> Some comments are outside the diff and can’t be posted inline due to platform limitations.\n> <details>\n> <summary>⚠️ Outside diff range comments (2)</summary>\n> <!-- ${OUTSIDE_A} -->\n> <!-- ${OUTSIDE_B} -->\n> </details>`, |
| 21 | + ...overrides, |
| 22 | + }; |
| 23 | +} |
| 24 | + |
| 25 | +describe("durable CodeRabbit outside-diff findings", () => { |
| 26 | + it("uses CodeRabbit's stable cr-comment markers as finding identities", () => { |
| 27 | + assert.deepEqual( |
| 28 | + coderabbitOutsideDiffFindingIds({ reviews: [review()], liveHeadSha: HEAD }), |
| 29 | + [OUTSIDE_A, OUTSIDE_B], |
| 30 | + ); |
| 31 | + }); |
| 32 | + |
| 33 | + it("keeps standalone outside-diff findings active without an inline thread", () => { |
| 34 | + assert.deepEqual( |
| 35 | + unresolvedFindingsClaim({ |
| 36 | + threads: [], |
| 37 | + reviews: [review()], |
| 38 | + liveHeadSha: HEAD, |
| 39 | + }), |
| 40 | + { |
| 41 | + code: "review_findings", |
| 42 | + unresolved: 2, |
| 43 | + byBot: { "coderabbitai[bot]": 2 }, |
| 44 | + }, |
| 45 | + ); |
| 46 | + }); |
| 47 | + |
| 48 | + it("adds outside-diff markers without double-counting the review actionable total", () => { |
| 49 | + assert.deepEqual( |
| 50 | + unresolvedFindingsClaim({ |
| 51 | + threads: [ |
| 52 | + { isResolved: false, author: { login: "coderabbitai[bot]" } }, |
| 53 | + ], |
| 54 | + reviews: [review()], |
| 55 | + liveHeadSha: HEAD, |
| 56 | + }), |
| 57 | + { |
| 58 | + code: "review_findings", |
| 59 | + unresolved: 3, |
| 60 | + byBot: { "coderabbitai[bot]": 3 }, |
| 61 | + }, |
| 62 | + ); |
| 63 | + }); |
| 64 | + |
| 65 | + it("a later clean CodeRabbit review on the same head clears older markers", () => { |
| 66 | + assert.deepEqual( |
| 67 | + unresolvedFindingsClaim({ |
| 68 | + threads: [], |
| 69 | + reviews: [ |
| 70 | + review({ id: 9000, submitted_at: "2026-08-07T05:00:00Z" }), |
| 71 | + review({ |
| 72 | + id: 9002, |
| 73 | + submitted_at: "2026-08-07T07:00:00Z", |
| 74 | + body: "**Actionable comments posted: 0**", |
| 75 | + }), |
| 76 | + ], |
| 77 | + liveHeadSha: HEAD, |
| 78 | + }), |
| 79 | + { code: null, unresolved: 0, byBot: {} }, |
| 80 | + ); |
| 81 | + }); |
| 82 | + |
| 83 | + it("ignores CodeRabbit markers from an older head and from human reviews", () => { |
| 84 | + assert.deepEqual( |
| 85 | + coderabbitOutsideDiffFindingIds({ |
| 86 | + reviews: [ |
| 87 | + review({ commit_id: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" }), |
| 88 | + review({ |
| 89 | + id: 9002, |
| 90 | + user: { login: "maintainer" }, |
| 91 | + submitted_at: "2026-08-07T07:00:00Z", |
| 92 | + }), |
| 93 | + ], |
| 94 | + liveHeadSha: HEAD, |
| 95 | + }), |
| 96 | + [], |
| 97 | + ); |
| 98 | + }); |
| 99 | + |
| 100 | + it("deduplicates repeated markers in the review body", () => { |
| 101 | + assert.deepEqual( |
| 102 | + coderabbitOutsideDiffFindingIds({ |
| 103 | + reviews: [ |
| 104 | + review({ |
| 105 | + body: `Outside diff range comments (1)\n<!-- ${OUTSIDE_A} -->\n<!-- ${OUTSIDE_A} -->`, |
| 106 | + }), |
| 107 | + ], |
| 108 | + liveHeadSha: HEAD, |
| 109 | + }), |
| 110 | + [OUTSIDE_A], |
| 111 | + ); |
| 112 | + }); |
| 113 | +}); |
0 commit comments