Repository navigation
Commit cf5910a
committed
fix(hosted-tools): one effective-transport decision, one hosted declaration
Follow-up to #924. Two defects a branch review found after that PR merged,
both reproduced before fixing.
Forward-auth validation diverged from routing. The wire check already asked
`providerMatchesRegistryTransport()` whether the config still points at the
registry's documented endpoint, but the forward-auth check above it read
`registry.authKind` unconditionally. A `preserveCustomDestination` row reused
under a custom endpoint keeps its own auth at runtime, so a forward-auth config
carrying `modelPreferHostedTools` validated clean while
`preferConfiguredHostedTools()` — which runs only on the non-forward branch —
never applied it. Both checks now start from the same decision, computed once
instead of twice.
Multi-container restoration emitted the hosted tool twice. #924 made stripping
walk every `additional_tools` container and made restoration walk them too. Tool
declarations are request-scoped: the containers are separate carriers for one
tool set, so restoring into each put `image_generation` on the wire once per
stripped container. Restore into the first stripped container only, which keeps
the capability without duplicating it.
Both driven red against dev: reverting the two source files fails exactly two
tests, one per defect. 248 pass across the four affected files, typecheck clean.1 parent 3e889a3 commit cf5910a
2 files changed
Lines changed: 14 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
709 | 709 | | |
710 | 710 | | |
711 | 711 | | |
712 | | - | |
713 | | - | |
714 | | - | |
715 | | - | |
716 | | - | |
717 | | - | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
718 | 718 | | |
719 | 719 | | |
720 | 720 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
724 | 724 | | |
725 | 725 | | |
726 | 726 | | |
727 | | - | |
728 | | - | |
729 | | - | |
730 | | - | |
731 | | - | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
732 | 732 | | |
733 | 733 | | |
734 | 734 | | |
| |||
788 | 788 | | |
789 | 789 | | |
790 | 790 | | |
791 | | - | |
792 | | - | |
793 | | - | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
794 | 794 | | |
795 | 795 | | |
796 | 796 | | |
| |||
0 commit comments