Skip to content

Commit cca48ad

Browse files
committed
docs(devlog): third root cause, and this one is not the infrastructure's fault
My second explanation was also wrong. Dev is not scanned on push - its last analysis is from 8/15, default setup runs weekly, and 0be660a is not an ancestor of that commit, so the code was never in a dev scan. Dev's 84 alerts are stale rather than current, which is the opposite of what I said they showed. The real answer: github-advanced-security posted the finding as an inline review comment on #1959 at 02:38:08Z, and #1963 promoted at 02:55:04Z. It sat in the review thread of a promotion PR for seventeen minutes - while I was editing that same PR's description. Not a coverage gap. I did not read the review comments on a PR I was actively rewriting. Three explanations for one mistake. The first two blamed infrastructure; the third is true and the least comfortable, which is roughly how that tends to go.
1 parent c9ea659 commit cca48ad

1 file changed

Lines changed: 17 additions & 7 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,22 @@ targeting the default branch. Every campaign PR targets `dev`, so none of them c
243243
CodeQL feedback at all — verified: `refs/pull/1959/head` and `refs/pull/1963/head` have analyses
244244
because they target `main`, while the `preview`-targeting pair have zero.
245245

246-
The actual root cause is duller and more useful: **`dev` is scanned on push, and nobody read
247-
the result.** It carries 84 open alerts against `main`'s 71. The finding was observable on the
248-
integration branch from the moment #1897 merged until promotion, and no step in this campaign
249-
ever looked. CodeQL is structurally absent from the `dev` PR flow *and* the post-merge alert
250-
list is not part of anyone's gate — those are two different holes, and I named neither the
251-
first time.
246+
**Second attempt, also wrong.** I then wrote that `dev` is scanned on push and nobody read the
247+
result. Both halves are false: `dev`'s most recent analysis is `02abe0afa` from 2026-08-15,
248+
default setup runs on a *weekly* schedule, and `0be660a2e` is not an ancestor of that commit —
249+
so the code was never in a `dev` scan at all. Its 84 alerts are stale, not current, which is the
250+
opposite of what I claimed they showed. Alert #87's only instances are `refs/heads/main` and
251+
`refs/pull/1959/head`. "Nobody read it" described a page that never displayed it.
252+
253+
**The actual missed signal, third time.** `github-advanced-security[bot]` posted the finding as
254+
an inline review comment on **#1959** at `src/providers/antigravity-models.ts:273` at
255+
**02:38:08Z**. #1963 promoted at **02:55:04Z**. It was sitting on a promotion PR, in the review
256+
thread, for **17 minutes** before the code reached `main` — and I was actively editing that PR's
257+
description during the window. Not a coverage gap. I did not look at the review comments on a
258+
PR I was in the middle of rewriting.
259+
260+
Three explanations for one mistake, the first two of which blamed infrastructure. The third is
261+
the one that is true and the least comfortable.
252262

253263
Severity in context: the input is a configured `baseUrl`, so exploitation needs a hostile or
254264
careless config rather than attacker-controlled traffic. Worth fixing, not urgent. Separately,
@@ -267,7 +277,7 @@ edge cases (empty string, all-slashes, no trailing slash, interior slashes).
267277

268278
**The root cause is a process one and belongs in the record.** #1897 merged on local focused
269279
tests plus `tsc`. That substitutes for CI on the axis it covers — behavior — and silently skips
270-
the axis it does not: static analysis. Waiting for full CI would have surfaced this before it
280+
the axis it does not: static analysis. ~~Waiting for full CI would have surfaced this before it~~
271281
reached `main`. The instruction for this run was to stop waiting on per-PR CI and gate once at
272282
the end, which is a reasonable trade for speed; the honest accounting is that it traded away
273283
exactly this class of finding, and the end-gate I ran (`bun test`, `typecheck`, `privacy:scan`)

0 commit comments

Comments
 (0)