Skip to content

Commit cc1a47b

Browse files
committed
fix(state): contain directory iteration failures
1 parent 88b3ae1 commit cc1a47b

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

‎src/responses/state.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,14 @@ export function recoverStaleResponseStateTemps(
162162
};
163163
let names: Iterable<string>;
164164
try { names = io.list(dir); } catch { return result; }
165+
let iterator: Iterator<string>;
166+
try { iterator = names[Symbol.iterator](); } catch { return result; }
165167
let scanned = 0;
166-
for (const name of names) {
168+
for (;;) {
169+
let next: IteratorResult<string>;
170+
try { next = iterator.next(); } catch { return result; }
171+
if (next.done) break;
172+
const name = next.value;
167173
scanned += 1;
168174
if (scanned > maxEntries || result.removed + result.failed >= maxCleanups) break;
169175
const match = RESPONSE_STATE_TEMP_NAME.exec(name);

‎tests/responses-state.test.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,17 @@ describe("Responses previous_response_id state", () => {
718718
expect(existsSync(join(home, second))).toBe(true);
719719
});
720720

721+
test("stale temp recovery remains best-effort when enumeration fails", () => {
722+
const result = recoverStaleResponseStateTemps(home, {
723+
list: function* () {
724+
yield "unrelated.txt";
725+
throw new Error("directory read failed");
726+
},
727+
});
728+
729+
expect(result).toEqual({ matched: 0, removed: 0, failed: 0, bytesRemoved: 0 });
730+
});
731+
721732
test("v1 Cursor snapshot migrates to versioned provider state", () => {
722733
mkdirSync(home, { recursive: true });
723734
writeFileSync(join(home, "responses-state.json"), JSON.stringify({

0 commit comments

Comments
 (0)