Repository navigation
Commit c67e596
committed
fix: stop masking a failed pool read and a dead pool credential
Two CodeRabbit findings on #4292. getPoolSettings tolerated an unparseable 2xx body, and toDto fills defaults, so a failed read rendered as a disabled pool with default values that the panel treated as loaded -- and the next save would have written that fabricated state over the real configuration. Empty-body tolerance now belongs to the write only, where an empty 2xx really is a success.
The keyed image path fell back to the pre-pick key snapshot when the selected reference would not resolve. The pick commits before returning, so that sent a non-idempotent POST with a credential the config no longer treats as active -- and specifically the key that was cooling. It is a configuration error now, and the new regression test asserts nothing reaches the upstream.1 parent 6318374 commit c67e596
3 files changed
Lines changed: 72 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
95 | 100 | | |
96 | 101 | | |
97 | 102 | | |
| |||
141 | 146 | | |
142 | 147 | | |
143 | 148 | | |
144 | | - | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
706 | 705 | | |
707 | 706 | | |
708 | 707 | | |
709 | | - | |
| 708 | + | |
710 | 709 | | |
711 | 710 | | |
| 711 | + | |
712 | 712 | | |
713 | | - | |
714 | | - | |
| 713 | + | |
715 | 714 | | |
716 | 715 | | |
717 | | - | |
718 | | - | |
719 | | - | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
720 | 729 | | |
721 | 730 | | |
722 | 731 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
734 | 734 | | |
735 | 735 | | |
736 | 736 | | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
737 | 787 | | |
738 | 788 | | |
739 | 789 | | |
| |||
0 commit comments