Skip to content

Commit bf8c9d7

Browse files
authored
Merge pull request #1978 from lidge-jun/codex/wave5-postscan
docs(devlog): record the post-scan resolution of CodeQL #87
2 parents 7cf8587 + f92bb56 commit bf8c9d7

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,3 +333,18 @@ introduced exactly one and fixed exactly that one* — is accurate. But they tak
333333
attacker-influenceable `baseUrl` input my own fix comment argues about, so leaving them
334334
unmentioned would be the convenient framing rather than the honest one. They are out of scope
335335
here and worth their own pass.
336+
### Post-scan resolution
337+
338+
The prediction above held. GitHub flipped **alert #87 to `fixed` at 03:17:06Z**, after
339+
`refs/heads/main` re-analyzed at `c49fed608`. So the fix is now confirmed on both axes: the code
340+
is right, and the scanner agrees.
341+
342+
One artifact to expect: `refs/pull/1959/head` will keep listing an `open` instance of #87 until
343+
that PR closes or its ref ages out. Anyone auditing by instance list rather than alert *state*
344+
will see it and reasonably ask — the alert itself reads `fixed`.
345+
346+
**Correction to the omissions count.** I wrote "30 occurrences" of `/\/+$/` across `src/`. 30 was
347+
the *file* count; measured now it is **39 occurrences across 27 files**, one of which is the
348+
comment explaining the removal. Understating the remaining debt inside the section whose whole
349+
purpose is to not understate it was the wrong direction to be wrong in. Repo-wide open alerts
350+
have also drifted from 71 to 70 with the same rescan.

0 commit comments

Comments
 (0)