Skip to content

Commit bf8926c

Browse files
committed
test(lab): check that the sync activation window's callees are synchronous
The existing guard scans the text between `Bun.serve` and `return server` for a body-level await. That window is 178 lines and calls ten free functions plus eleven receiver methods. If one of those callees becomes `async`, startServer no longer waits for it, the ordering the window exists to protect is gone, and the window text still has no `await` in it, so all four existing checks stay green. `activateLab` is the function that ordering is about. Making it async is a one-word change that the guard could not see. Two checks close that. "functions the window calls are synchronous" collects the body-level call sites in the window, splits them into free functions and receiver methods, resolves each free function through src/server/index.ts's imports and one level of re-export to the module that declares it, and asserts the declaration is not `async` and its body has no body-level await. Names it cannot resolve go in UNRESOLVED_CALLEES with a reason rather than being skipped, because a silent skip is how this kind of check rots. Receiver methods go in SYNC_WINDOW_RECEIVER_CALLS, and the collected set must match that list exactly, so a new `obj.method()` in the window fails the test and forces a review. Depth is one on purpose. Walking every function those callees invoke produces false positives on dynamic dispatch, and the regression this exists to catch lands at depth one. "the callee scan is not vacuous" pins the scanner against synthetic input and fails if the collector finds no free function at all, which is how a collapsed window would otherwise measure an empty string and pass. Driven red to prove it is not vacuous: declaring src/lib/lab-activation.ts's `activateLab` `async` leaves all four existing checks green and fails only the new one, with "activateLab in src/lib/lab-activation.ts: declared async". The declaration was restored; the suite is 19 pass / 0 fail.
1 parent 9b71107 commit bf8926c

1 file changed

Lines changed: 558 additions & 1 deletion

File tree

0 commit comments

Comments
 (0)