Repository navigation
Commit befcac3
committed
fix(release): move dev's version line past the published preview
dev's package.json said 2.35.0 while the repository had already published
v2.36.0-preview.20260829 (npm dist-tags: preview=2.36.0-preview.20260829,
latest=2.35.0). The preview bump was cut on the prerelease train and never came
back to dev, so tests/release-version-line.test.ts fails on every commit that
descends from dev:
release version line > the in-tree version is never behind a released one
package.json version 2.35.0 is BEHIND the highest release tag
v2.36.0-preview.20260829
That is inherited red, not a defect in any of the pull requests hitting it. It
currently fails test 2/4, test 3/4, test 4/4, and macos on #2835, #2822, #2821,
#2796, #2797, and #2785 - six bug PRs whose own diffs are unrelated to release
tooling. Rebasing them onto an unrepaired dev cannot turn them green, which is
why this lands first.
2.36.0 rather than a preview suffix follows the precedent this repository set
twice: e4a85d1 moved dev to 2.34.0 when it trailed a published 2.33.0, and
076ad30 moved dev to 2.35.0 right after v2.34.0 shipped. dev carries the next
stable version; the preview train adds its own suffix at release time.
The value was chosen by running the repository's own comparator rather than by
reading it. Against the highest tag v2.36.0-preview.20260829, compareReleaseTags
returns -1 for 2.35.0 and 2.35.1, 0 for 2.36.0-preview.20260829 (legal only on
the commit that tag names, which a dev merge commit is not), and +1 for 2.36.0.
npm view @bitkyc08/[email protected] returns E404 and git tag --list v2.36.0 is
empty, so the string is unused.
Verification on this branch:
bun test tests/release-version-line.test.ts 3 pass 0 fail (was 2 pass 1 fail)
bun test tests/release-helper.test.ts 5 pass 0 fail
bun test tests/compatibility-version.test.ts 1 pass 0 fail1 parent 1a18ace commit befcac3
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments