Repository navigation
Commit bee1cc7
committed
fix(startup): recommend repair for an installed service, not re-registration
Second instance of the same defect the docs commit fixed, found while checking
whether that fix was complete.
startupHealthSummary() renders 'background service files are stale' and
'installed service is disabled, stopped, or unhealthy' — both cases where a
service is already REGISTERED — and then told the user to run
'ocx service install'. The dashboard recovery panel hardcoded the same command
in its copy button.
install re-registers: it needs elevation on Windows (schtasks /create) and its
transactional backend switch can replace a WinSW install with Task Scheduler.
So the advice handed a UAC prompt and a possible backend change to someone whose
only problem was stale assets. repair rewrites those assets and restarts the
existing registration in place.
recommendedCommand now picks repair when serviceInstalled and not conflicting;
a genuinely absent service still gets install, and a conflict still gets install
because repairService() refuses a two-manager conflict outright and the user must
uninstall first. The GUI derives its command the same way instead of hardcoding.
Red-green: restoring the unconditional installService fails the stale/disabled/
stopped guard. The DTO contract test was updated for the new commands entry, and
eslint caught the constant landing in the tray section rather than the recovery
section it renders in.
11 pass / 0 fail autostart-health, 583 pass / 0 fail gui.1 parent ba68e90 commit bee1cc7
4 files changed
Lines changed: 49 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
228 | 236 | | |
229 | 237 | | |
230 | 238 | | |
| |||
237 | 245 | | |
238 | 246 | | |
239 | 247 | | |
240 | | - | |
| 248 | + | |
241 | 249 | | |
242 | | - | |
243 | | - | |
| 250 | + | |
| 251 | + | |
244 | 252 | | |
245 | 253 | | |
246 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
92 | 98 | | |
93 | 99 | | |
94 | 100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
36 | 65 | | |
37 | 66 | | |
38 | 67 | | |
| |||
171 | 200 | | |
172 | 201 | | |
173 | 202 | | |
| 203 | + | |
174 | 204 | | |
175 | 205 | | |
176 | 206 | | |
| |||
0 commit comments