Repository navigation
Commit 9eb7f0b
committed
fix(registry): fill per-model modality defaults beneath user overrides
Addresses review feedback on the xAI vision fix.
enrichProviderFromRegistry filled modelInputModalities all-or-nothing, so a
single customized model in a persisted config suppressed the registry map
entirely. A user who narrowed one grok model would leave grok-4.5 with no
declared modalities, which put the combo aggregator back on its ["text"]
default and re-hid image support.
Routing already merges these maps per key (mergeRecordFill in src/router.ts).
Catalog enrichment now matches, so registry defaults fill in beneath the
user's entries instead of being skipped wholesale. Explicit user values still
win per model.
Also broaden the registry assertion to cover all four vision-capable grok ids
and both text-only exclusions, so a regression in any single entry fails.1 parent 9441ed3 commit 9eb7f0b
2 files changed
Lines changed: 50 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
81 | 98 | | |
82 | 99 | | |
83 | 100 | | |
| |||
211 | 228 | | |
212 | 229 | | |
213 | 230 | | |
214 | | - | |
| 231 | + | |
215 | 232 | | |
216 | 233 | | |
217 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
157 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
158 | 166 | | |
159 | | - | |
160 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
161 | 171 | | |
162 | 172 | | |
163 | 173 | | |
| |||
200 | 210 | | |
201 | 211 | | |
202 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
203 | 232 | | |
0 commit comments