Skip to content

Commit 871e96f

Browse files
committed
fix(ci): skip bun --isolate on macOS to avoid Bun 1.3.14 segfault
Churn caps and afterAll settle still left macos-latest red with exit 133 after storage-worker-teardown passed (balanced worker counts). Run the same suite without --isolate on macOS; keep isolate on Linux/Windows.
1 parent 58ed4c8 commit 871e96f

3 files changed

Lines changed: 18 additions & 4 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,16 @@ jobs:
8181
- name: Typecheck
8282
run: bun x tsc --noEmit
8383

84-
- name: Test
84+
# Bun 1.3.14 under `--isolate` segfaults on macOS Silicon CI after storage
85+
# Worker suites finish with balanced workers_spawned/terminated (exit 133 /
86+
# Trace/BPT). Caps/settles in the teardown suite did not stop it. Run the
87+
# same tests without isolate on macOS; keep isolate on Linux/Windows.
88+
- name: Test (macOS)
89+
if: runner.os == 'macOS'
90+
run: bun test tests
91+
92+
- name: Test (Linux/Windows, isolated)
93+
if: runner.os != 'macOS'
8594
run: bun test --isolate tests
8695

8796
- name: GUI tests

‎tests/ci-workflows.test.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,11 @@ describe("GitHub Actions hardening", () => {
4242
expect(workflow).toContain("actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0");
4343
expect(workflow).toContain("oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6");
4444
expect(workflow).toContain("actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e");
45+
// macOS skips `--isolate` (Bun 1.3.14 Silicon exit-133); Linux/Windows keep it.
4546
expect(workflow).toContain("bun test --isolate tests");
47+
expect(workflow).toMatch(/if:\s*runner\.os\s*==\s*'macOS'/);
48+
expect(workflow).toMatch(/if:\s*runner\.os\s*!=\s*'macOS'/);
49+
expect(workflow).toMatch(/run:\s*bun test tests/);
4650
expect(workflow).not.toMatch(/uses:\s+\S+@(?:v\d+|main|master)\b/);
4751
});
4852

‎tests/storage-worker-teardown-isolate.test.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
*
99
* A second Bun 1.3.14 failure mode is a post-suite segfault with a *balanced*
1010
* `workers_spawned === workers_terminated` count (exit 133 / Trace/BPT on
11-
* macOS Silicon CI). That is a runtime crash after green assertions — keep the
12-
* heavy churn on win32, and leave darwin with a single-cycle proof plus a
13-
* brief settle before the isolate file boundary.
11+
* macOS Silicon CI). Caps/settles here were not enough under GHA load, so
12+
* cross-platform CI runs macOS without `--isolate` (see `.github/workflows/ci.yml`).
13+
* Keep the heavy churn on win32; darwin stays at a single-cycle proof for local
14+
* isolate runs.
1415
*
1516
* These cases hammer the exact failure window: fire-and-forget terminate must
1617
* still be joinable by drain, and repeated spawn → reset cycles must leave the

0 commit comments

Comments
 (0)