Repository navigation
Commit 84ade0f
fix(codex): keep oversized Responses turns off the WS transport (#2473)
* fix(codex): keep oversized Responses turns off the WS transport
The Codex backend closes the socket on any inbound message of 16 MiB or
more without sending a Responses terminal event, which reached clients as
a bare 502 upstream_server_error. Because the wrapper only fell back to
SSE when the *upgrade* failed, a thread that crossed the ceiling could
never recover: every retry resent the same oversized frame.
Measured against the live endpoint on 2026-08-23: 16,777,000 B completed,
16,777,300 B closed the socket in ~1s, reproducibly. The same body still
succeeds over HTTP SSE, so the limit belongs to this transport alone.
Size the `response.create` frame before dialing and take the SSE path when
it does not fit. Deciding before the socket opens is what keeps the resend
safe -- after open the caller already holds a streaming Response, and a
retry there could double-generate the turn.
Two supporting changes:
- Carry the WS close code and reason into the stream error. A 1009 was
previously indistinguishable from a network drop, and nothing in
usage.jsonl or /api/logs recorded the real cause.
- Apply the provider's `upstreamHttpVersion` pin to the SSE fallback. The
fallback is a routine path now, and serving a turn over HTTP while
silently dropping the operator's protocol pin is wrong.
Co-Authored-By: Claude Fable 5 <[email protected]>
* test(codex): pin the transport boundary at the adjacent byte
The sizing helper already had unit tests, but nothing proved the real
serialized frame routes correctly one byte on each side of the limit.
That gap matters because the request body is not the frame: `stream` is
deleted and `type` is added before sending, so padding sized against the
body sits eleven bytes away from what is actually transmitted. An
off-by-one would live exactly there and pass every existing test.
These two build padding so the serialized frame is exactly limit-1 and
exactly limit, then assert the whole path: one socket and one send of the
expected byte length under, zero sockets and one SSE call at it. Flipping
the gate from >= to > fails the second one, so it catches a real
off-by-one at the transport level rather than only in the helper.
Two comment corrections while here. The close-code comment claimed the
named 1009 message makes the failure diagnosable from the logs; it does
not. The eager relay turns any stream error into a generic
`upstream_reset` synthetic terminal without feeding it back through the
inspector, so `/api/logs` retains only `streamAborted`. The message
reaches the client and stops there, and the comment now says so rather
than promising observability the code does not deliver.
The margin comment described 64 KiB as absorbing a future append. There
is no append. It is a conservative cushion, and the useful thing to
record is what it actually covers: RFC 6455 framing is 14 bytes at this
payload size — an 8-byte extended length plus a 4-byte client mask — so
even a backend counting frame headers has ~65.5 KiB of room.
Tests: 59 pass, 1 skip across ws-upstream, sse-failed-tail, and
upstream-http-version. tsc --noEmit clean.
---------
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: bitkyc08-arch <[email protected]>1 parent a60d517 commit 84ade0f
3 files changed
Lines changed: 254 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
67 | 75 | | |
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
71 | 79 | | |
72 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
73 | 85 | | |
74 | | - | |
| 86 | + | |
75 | 87 | | |
76 | 88 | | |
77 | 89 | | |
| |||
87 | 99 | | |
88 | 100 | | |
89 | 101 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | 102 | | |
94 | 103 | | |
95 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
31 | 50 | | |
32 | 51 | | |
33 | 52 | | |
| |||
102 | 121 | | |
103 | 122 | | |
104 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
105 | 170 | | |
106 | 171 | | |
107 | 172 | | |
| |||
127 | 192 | | |
128 | 193 | | |
129 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
130 | 203 | | |
131 | 204 | | |
132 | 205 | | |
| |||
279 | 352 | | |
280 | 353 | | |
281 | 354 | | |
282 | | - | |
| 355 | + | |
283 | 356 | | |
284 | 357 | | |
285 | 358 | | |
| |||
297 | 370 | | |
298 | 371 | | |
299 | 372 | | |
300 | | - | |
| 373 | + | |
301 | 374 | | |
302 | 375 | | |
303 | 376 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
| |||
672 | 675 | | |
673 | 676 | | |
674 | 677 | | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
0 commit comments