Skip to content

Commit 82c0576

Browse files
authored
Merge pull request #1982 from lidge-jun/codex/promote-preview-w5f
Promote dev to preview: final Wave 5 errata
2 parents c0961d8 + e1bdbc1 commit 82c0576

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,13 +275,18 @@ The input is provider config rather than hostile traffic, so the practical risk
275275
nothing. Replaced with `stripTrailingSlashes`, verified byte-identical to the regex across the
276276
edge cases (empty string, all-slashes, no trailing slash, interior slashes).
277277

278-
**The root cause is a process one and belongs in the record.** #1897 merged on local focused
278+
> **This entire paragraph is superseded by the third explanation above.** It survives as the
279+
> record of a wrong answer, not as an answer. Full CI would *not* have surfaced this: CodeQL
280+
> never runs on a `dev`-targeting PR, so no amount of waiting on per-PR CI would have shown it.
281+
> The signal that was actually missed was a review comment on a promotion PR, not a CI job.
282+
283+
~~**The root cause is a process one and belongs in the record.** #1897 merged on local focused
279284
tests plus `tsc`. That substitutes for CI on the axis it covers — behavior — and silently skips
280-
the axis it does not: static analysis. ~~Waiting for full CI would have surfaced this before it~~
285+
the axis it does not: static analysis. Waiting for full CI would have surfaced this before it
281286
reached `main`. The instruction for this run was to stop waiting on per-PR CI and gate once at
282287
the end, which is a reasonable trade for speed; the honest accounting is that it traded away
283288
exactly this class of finding, and the end-gate I ran (`bun test`, `typecheck`, `privacy:scan`)
284-
does not include CodeQL.
289+
does not include CodeQL.~~
285290

286291
For context rather than excuse: the repository carries 71 open alerts, 65 of them high or
287292
critical. This is one of many — but it is one this campaign put there, so it gets fixed here
@@ -325,7 +330,7 @@ JS/TS run there; until it does, this campaign does not claim it closed.
325330

326331
A reviewer asked whether other instances of the same pattern remain. **Yes — 30 occurrences of
327332
`/\/+$/` across `src/`**, with open `js/polynomial-redos` alerts on at least six
328-
(#83, #84, #60, #53, #51, #52) covering `openai-chat-url.ts`, `openai-responses-url.ts`,
333+
(#83, #60, #53, #52, #51, #50) covering `openai-chat-url.ts`, `openai-responses-url.ts`,
329334
`openai-responses.ts`, `openai-chat.ts` and `anthropic.ts`.
330335

331336
All predate this campaign (created 2026-08-12/13), so the scoped claim — *this campaign
@@ -348,3 +353,12 @@ the *file* count; measured now it is **39 occurrences across 27 files**, one of
348353
comment explaining the removal. Understating the remaining debt inside the section whose whole
349354
purpose is to not understate it was the wrong direction to be wrong in. Repo-wide open alerts
350355
have also drifted from 71 to 70 with the same rescan.
356+
**Correction to the alert list.** The six I named included **#84**, which had already been fixed
357+
at 03:03:30Z — before I wrote the list — and omitted **#50**, which is open. Still six, but one
358+
member was wrong. The live open set is #83, #60, #53, #52, #51, #50, all created 2026-08-12/13,
359+
which leaves the scoped claim intact: this campaign introduced exactly one `js/polynomial-redos`
360+
alert and fixed exactly that one.
361+
362+
**And the one it introduced is now closed.** Alert #87 reads `fixed`, `fixed_at
363+
2026-08-18T03:17:06Z`, from the JS/TS rescan of `main` at `1f4e0470e`. The earlier text
364+
predicted this would happen on the next scan and declined to claim it had; the prediction held.

0 commit comments

Comments
 (0)