Skip to content

Commit 826a1b7

Browse files
authored
Merge pull request #2224 from luvs01/agent/cursor-eof-terminal-budget-current
fix(cursor): catch EOF terminal budget overflow
2 parents ac76fd9 + deacd53 commit 826a1b7

2 files changed

Lines changed: 55 additions & 1 deletion

File tree

‎src/adapters/cursor/live-transport.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1129,7 +1129,7 @@ class LiveCursorTransport implements CursorTransport {
11291129
}
11301130
releaseBacklogLease();
11311131
settler.settleFinish();
1132-
}, (err) => {
1132+
}).catch((err) => {
11331133
failAndClear(err instanceof Error ? err : new Error(String(err)));
11341134
});
11351135
};

‎tests/cursor-hardening.test.ts‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,60 @@ describe("Cursor live transport unexpected EOF", () => {
623623
expect(seenSessionId).toBe("cursor_from_gjc_session");
624624
});
625625

626+
test("settles as a failure when clean EOF synthesis exceeds the transport budget", async () => {
627+
const textFrame = encodeConnectFrame(toBinary(AgentServerMessageSchema, create(AgentServerMessageSchema, {
628+
message: {
629+
case: "interactionUpdate",
630+
value: create(InteractionUpdateSchema, {
631+
message: {
632+
case: "textDelta",
633+
value: create(TextDeltaUpdateSchema, { text: "x" }),
634+
},
635+
}),
636+
},
637+
})));
638+
const connectEnd = encodeConnectFrame(new TextEncoder().encode("{}"), {
639+
flags: CONNECT_FLAG_END_STREAM,
640+
});
641+
642+
await withDiscoveryServer(stream => {
643+
stream.respond({ ":status": 200, "content-type": "application/connect+proto" });
644+
stream.end(Buffer.from(new Uint8Array([
645+
...Array.from({ length: 37 }, () => [...textFrame]).flat(),
646+
...connectEnd,
647+
])));
648+
}, async baseUrl => {
649+
const budget = createTestTranslatorBudget({ maxTurnBytes: 1_000 });
650+
const transport = createLiveCursorTransport({
651+
provider: { adapter: "cursor", baseUrl, apiKey: "test-token" },
652+
translatorBudget: budget,
653+
firstFrameTimeoutMs: 2_000,
654+
});
655+
const iterator = transport.run({
656+
modelId: "composer-2",
657+
conversationId: "cursor_clean_eof_budget_test",
658+
system: [],
659+
messages: [{ role: "user", content: "hello" }],
660+
})[Symbol.asyncIterator]();
661+
let failure: Error | undefined;
662+
try {
663+
expect(await iterator.next()).toMatchObject({ value: { type: "text" } });
664+
await Bun.sleep(20);
665+
while (!(await iterator.next()).done) {}
666+
} catch (err) {
667+
failure = err instanceof Error ? err : new Error(String(err));
668+
} finally {
669+
await transport.close?.();
670+
}
671+
672+
expect(failure).toMatchObject({
673+
name: "TranslatorBudgetExceededError",
674+
code: "translation_buffer_limit",
675+
});
676+
expect(budget.snapshot().currentBytes).toBe(0);
677+
});
678+
});
679+
626680
test("synthesizes done after createPlanRequestQuery text on clean Connect EOF", async () => {
627681
const planFrame = encodeConnectFrame(toBinary(AgentServerMessageSchema, create(AgentServerMessageSchema, {
628682
message: {

0 commit comments

Comments
 (0)