Skip to content

Commit 7cf8587

Browse files
authored
Merge pull request #1973 from lidge-jun/codex/wave5-alert-precision
docs(devlog): separate fixed-in-code from closed-by-scan for CodeQL #87
2 parents ac8e0e4 + f1586f0 commit 7cf8587

1 file changed

Lines changed: 28 additions & 0 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,3 +305,31 @@ returns true. The alert is disclosed on #1897, on both promotion PR pairs, and h
305305
What I did not do, and stand by: I never approved a promotion PR. `MAINTAINERS.md` forbids
306306
authors approving their own, and the rulesets require a code-owner review. That the promotion
307307
happened by another route is the maintainer's call to make, not mine to route around.
308+
### Alert #87: verified fixed on the code, not yet flipped by GitHub
309+
310+
Stating this precisely, because "fixed" and "closed" are different claims and only one of them
311+
is currently provable.
312+
313+
**The code is fixed and promoted.** `59d57a9bf` is an ancestor of `dev`, `preview` and `main`,
314+
and all three trees are byte-identical. A reviewer fuzzed 400,000 adversarial strings — slashes,
315+
`\u2028`, lone surrogates, NUL — against the replaced regex and found **zero** behavioral
316+
differences.
317+
318+
**The alert still reads `open`.** That is scan lag, not a live finding: the most recent
319+
JavaScript/TypeScript analysis on `main` ran at `7979903b9`, which predates the fix. Queried
320+
against `refs/pull/1968/head` — the branch that *does* contain it — alert #87 returns **zero**.
321+
So the fix is confirmed by scan, just not yet on the `main` ref. It should flip on the next
322+
JS/TS run there; until it does, this campaign does not claim it closed.
323+
324+
### What I did not fix, and should say so
325+
326+
A reviewer asked whether other instances of the same pattern remain. **Yes — 30 occurrences of
327+
`/\/+$/` across `src/`**, with open `js/polynomial-redos` alerts on at least six
328+
(#83, #84, #60, #53, #51, #52) covering `openai-chat-url.ts`, `openai-responses-url.ts`,
329+
`openai-responses.ts`, `openai-chat.ts` and `anthropic.ts`.
330+
331+
All predate this campaign (created 2026-08-12/13), so the scoped claim — *this campaign
332+
introduced exactly one and fixed exactly that one* — is accurate. But they take the same
333+
attacker-influenceable `baseUrl` input my own fix comment argues about, so leaving them
334+
unmentioned would be the convenient framing rather than the honest one. They are out of scope
335+
here and worth their own pass.

0 commit comments

Comments
 (0)